From dev-return-95937-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Mon Jun 28 10:56:33 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4ABAE180645 for ; Mon, 28 Jun 2021 12:56:33 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 32C823FDF1 for ; Mon, 28 Jun 2021 10:56:31 +0000 (UTC) Received: (qmail 17266 invoked by uid 500); 28 Jun 2021 10:56:30 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 17256 invoked by uid 99); 28 Jun 2021 10:56:30 -0000 Received: from spamproc1-he-de.apache.org (HELO spamproc1-he-de.apache.org) (116.203.196.100) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jun 2021 10:56:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-de.apache.org (ASF Mail Server at spamproc1-he-de.apache.org) with ESMTP id B01E81FF48A for ; Mon, 28 Jun 2021 10:56:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-de.apache.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=6.31 tests=[SPF_PASS=-0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([116.203.227.195]) by localhost (spamproc1-he-de.apache.org [116.203.196.100]) (amavisd-new, port 10024) with ESMTP id g8SKOGjp_ZUY for ; Mon, 28 Jun 2021 10:56:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.91.35.233; helo=mail.greenbytes.de; envelope-from=stefan.eissing@greenbytes.de; receiver= Received: from mail.greenbytes.de (mail.greenbytes.de [217.91.35.233]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id CE922BC489 for ; Mon, 28 Jun 2021 10:56:27 +0000 (UTC) Received: by mail.greenbytes.de (Postfix, from userid 119) id 16E1B984DEC; Mon, 28 Jun 2021 12:56:20 +0200 (CEST) Received: from smtpclient.apple (unknown [93.207.154.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail.greenbytes.de (Postfix) with ESMTPSA id 52B029802BD for ; Mon, 28 Jun 2021 12:56:19 +0200 (CEST) From: Stefan Eissing Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: mpm state changes Date: Mon, 28 Jun 2021 12:56:18 +0200 References: To: dev@httpd.apache.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3654.100.0.2.22) > Am 28.06.2021 um 11:18 schrieb Yann Ylavic : >=20 > On Mon, Jun 28, 2021 at 10:28 AM Stefan Eissing > wrote: >>=20 >> what do you think about adding a hook for MPMQ state changes? >>=20 >> AP_MPMQ_STARTING -> AP_MPMQ_RUNNING -> AP_MPMQ_STOPPING >=20 > Fine by me, we just need to make sure that the hooks are not called > from signal handlers (e.g. MPM prefork sets AP_MPMQ_STOPPING in the > stop_listening() handler). Right. Let's say we restrict this to changes in child processes. As in: 1. AP_DECLARE_HOOK(void,child_running,(apr_pool_t *pchild, server_rec = *s))=20 2. AP_DECLARE_HOOK(void,child_stopping,(apr_pool_t *pchild, server_rec = *s, int graceful))=20 1 could be called in the mpm's "child_main()" function. 2.could be called event.c#1326: in close_listeners() worker.c#714: listener_thread() exits its loop winnt/child.c#1145: at start of shutdown prefork.c: does not set _STOPPING in child processes it seems. 2 might = be called in line 681 netware: is this still maintained? os2: does not care about MPMQ_* things (is this still maintained?) motorz: line 948 simple: does not really care about MPMQ_=20 - Stefan=