From dev-return-95910-archive-asf-public=cust-asf.ponee.io@httpd.apache.org Tue Jun 22 07:39:39 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 2A266180669 for ; Tue, 22 Jun 2021 09:39:39 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 1187F61446 for ; Tue, 22 Jun 2021 07:39:32 +0000 (UTC) Received: (qmail 89112 invoked by uid 500); 22 Jun 2021 07:39:30 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 89094 invoked by uid 99); 22 Jun 2021 07:39:30 -0000 Received: from spamproc1-he-de.apache.org (HELO spamproc1-he-de.apache.org) (116.203.196.100) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jun 2021 07:39:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-de.apache.org (ASF Mail Server at spamproc1-he-de.apache.org) with ESMTP id 98E101FF4B9 for ; Tue, 22 Jun 2021 07:39:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-de.apache.org X-Spam-Flag: NO X-Spam-Score: 0.1 X-Spam-Level: X-Spam-Status: No, score=0.1 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, POISEN_SPAM_PILL_3=0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamproc1-he-de.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=sharp.fm Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-de.apache.org [116.203.196.100]) (amavisd-new, port 10024) with ESMTP id jl8UVukl7zPe for ; Tue, 22 Jun 2021 07:39:29 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:470:18b1:0:5054:ff:fe6e:d541; helo=chandler.sharp.fm; envelope-from=minfrin@sharp.fm; receiver= Received: from chandler.sharp.fm (chandler.sharp.fm [IPv6:2001:470:18b1:0:5054:ff:fe6e:d541]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTP id 392BE7FFE1 for ; Tue, 22 Jun 2021 07:39:29 +0000 (UTC) Received: from smtpclient.apple (unknown [IPv6:2001:470:18b1:1:3cca:8720:1e3d:8406]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: minfrin@sharp.fm) by chandler.sharp.fm (Postfix) with ESMTPSA id 1F119A525C for ; Tue, 22 Jun 2021 08:39:22 +0100 (BST) Authentication-Results: chandler.sharp.fm; arc=none smtp.client-ip=2001:470:18b1:1:3cca:8720:1e3d:8406 ARC-Seal:i=1; a=rsa-sha256; d=sharp.fm; s=default; t=1624347563; cv=none; b=WO/lIHprfFv/hd2aRGc0zrw/6Zcs1nnvG/11DTBNxT4ZLr52opwHS5Ixe8VQ8qUKJBDWzLl2pF4jxpJF++rirGi6/ITcyN1NvDUuBNckjGyyGOKQHH9Xeta1uWfOIHMhKRiPkv8jla/pj8ctcESkmnqC7BM0C6KYKgEXCCcUkpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=sharp.fm; s=default; t=1624347563; c=relaxed/simple; bh=QEu4IUpBV9pjSLZCM997m3Vu91JdBGMEZTR4cCnZVLE=; h=DKIM-Filter:DKIM-Signature:From:Content-Type:Mime-Version:Subject: Date:References:To:In-Reply-To:Message-Id:X-Mailer; b=CY6EG/9CphNpoupwwxlTPqUo4evQ4N5Ki/XHs8sWnLBK/rCBZXaYRdo76H3vSk+LNeiC0V6ZW5sCtQkvcqVzhzvU39qnGTBqMKjBpGUaanRJFmwQ7xd8iYRk4mOXGfjporEwl4LEyhLRCE0ggKM/jTGZoyB2At3wOEoRY3DE/l8= ARC-Authentication-Results:i=1; chandler.sharp.fm; arc=none smtp.client-ip=2001:470:18b1:1:3cca:8720:1e3d:8406 DKIM-Filter: OpenDKIM Filter v2.11.0 chandler.sharp.fm 1F119A525C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharp.fm; s=default; t=1624347563; bh=7oc7zQH1hpAdZ49qsUP9hirHeQB23mJ/K4HT7wq/uog=; h=From:Subject:Date:References:To:In-Reply-To:From; b=MZPnMs0rWR4DsYN6SF3igUAFfISf9ceqY+yLE+8gUSijwH35GNDyztNznkF9I2wpJ Clw86rfOluXFNl82cx+vD6R+ahh2E/S9GiYUM48q/2/F4d7O6Mda4Dt2NIRhCjJi7T mrV4LyvlPjrX4RW9lCH1eqyUT8GIPNfF7VDCtLs4= From: Graham Leggett Content-Type: multipart/alternative; boundary="Apple-Mail=_43B4A2BC-1CB7-42BD-9F8C-AB9549B1F70C" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: svn commit: r1890947 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS include/ap_mmn.h modules/proxy/mod_proxy.h modules/proxy/mod_proxy_ajp.c modules/proxy/mod_proxy_balancer.c modules/proxy/mod_proxy_hcheck.c Date: Tue, 22 Jun 2021 09:39:22 +0200 References: <20210621170335.7E5F417B518@svn01-us-east.apache.org> To: dev@httpd.apache.org In-Reply-To: Message-Id: <86DE59C0-3DEB-49DF-B930-8509B100BAC5@sharp.fm> X-Mailer: Apple Mail (2.3654.100.0.2.22) --Apple-Mail=_43B4A2BC-1CB7-42BD-9F8C-AB9549B1F70C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 On 22 Jun 2021, at 09:09, Ruediger Pluem wrote: >> + timeout =3D apr_time_from_sec(10); /* 10 seconds */ >=20 > Sorry for jumping on this late, but as I already mentioned on the = original trunk revision a hard coded timeout is bad. > Please also backport r1887439. For the record I am +1 on backporting = r1887439. +1 to this. I=E2=80=99ve proposed it here: = http://svn.apache.org/viewvc?rev=3D1890960&view=3Drev = Regards, Graham =E2=80=94 --Apple-Mail=_43B4A2BC-1CB7-42BD-9F8C-AB9549B1F70C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 On = 22 Jun 2021, at 09:09, Ruediger Pluem <rpluem@apache.org> = wrote:

+ =    timeout =3D apr_time_from_sec(10); /* 10 seconds */

Sorry for jumping on this late, but as I already mentioned on = the original trunk revision a hard coded timeout is bad.
Please also = backport r1887439. For the record I am +1 on backporting = r1887439.

+1 = to this.

I=E2=80=99ve proposed it = here: http://svn.apache.org/viewvc?rev=3D1890960&view=3Drev

Regards,
Graham
=E2=80=94
<= div>
= --Apple-Mail=_43B4A2BC-1CB7-42BD-9F8C-AB9549B1F70C--