Return-Path: Delivered-To: apmail-httpd-apreq-cvs-archive@www.apache.org Received: (qmail 42867 invoked from network); 13 Oct 2005 02:07:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 13 Oct 2005 02:07:49 -0000 Received: (qmail 3598 invoked by uid 500); 13 Oct 2005 02:07:49 -0000 Delivered-To: apmail-httpd-apreq-cvs-archive@httpd.apache.org Received: (qmail 3578 invoked by uid 500); 13 Oct 2005 02:07:49 -0000 Mailing-List: contact apreq-cvs-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: apreq-dev@httpd.apache.org List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list apreq-cvs@httpd.apache.org Received: (qmail 3567 invoked by uid 99); 13 Oct 2005 02:07:48 -0000 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 12 Oct 2005 19:07:48 -0700 Received: (qmail 42791 invoked by uid 65534); 13 Oct 2005 02:07:28 -0000 Message-ID: <20051013020728.42790.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r320610 - /httpd/apreq/trunk/glue/perl/xsbuilder/APR/Request/Cookie/APR__Request__Cookie.h Date: Thu, 13 Oct 2005 02:07:28 -0000 To: apreq-cvs@httpd.apache.org From: joes@apache.org X-Mailer: svnmailer-1.0.5 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: joes Date: Wed Oct 12 19:07:26 2005 New Revision: 320610 URL: http://svn.apache.org/viewcvs?rev=320610&view=rev Log: on get/set methods, we want $cookie->method(undef) to set a NULL pointer into the corresponding slot. The original code doesn't do that, it sets an empty string instead. Modified: httpd/apreq/trunk/glue/perl/xsbuilder/APR/Request/Cookie/APR__Request__Cookie.h Modified: httpd/apreq/trunk/glue/perl/xsbuilder/APR/Request/Cookie/APR__Request__Cookie.h URL: http://svn.apache.org/viewcvs/httpd/apreq/trunk/glue/perl/xsbuilder/APR/Request/Cookie/APR__Request__Cookie.h?rev=320610&r1=320609&r2=320610&view=diff ============================================================================== --- httpd/apreq/trunk/glue/perl/xsbuilder/APR/Request/Cookie/APR__Request__Cookie.h (original) +++ httpd/apreq/trunk/glue/perl/xsbuilder/APR/Request/Cookie/APR__Request__Cookie.h Wed Oct 12 19:07:26 2005 @@ -14,6 +14,9 @@ apr_pool_t *p; SV *parent; + if (!SvOK(value)) + return NULL; + v = SvPV(value, vlen); mg = mg_find(obj, PERL_MAGIC_ext); iv = SvIVX(mg->mg_obj);