From issues-return-415717-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Tue Dec 3 03:23:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C5E3218064E for ; Tue, 3 Dec 2019 04:23:02 +0100 (CET) Received: (qmail 77646 invoked by uid 500); 3 Dec 2019 03:23:01 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 77629 invoked by uid 99); 3 Dec 2019 03:23:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Dec 2019 03:23:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A0C03E0E2E for ; Tue, 3 Dec 2019 03:23:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 1D416780778 for ; Tue, 3 Dec 2019 03:23:00 +0000 (UTC) Date: Tue, 3 Dec 2019 03:23:00 +0000 (UTC) From: "chenxu (Jira)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: =?utf-8?Q?[jira]_[Commented]_(HBASE-23355)_Add=C2=A0a_conf_key?= =?utf-8?Q?_to_decide_which_operations_can_trigger_prefetch?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-23355?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D169= 86576#comment-16986576 ]=20 chenxu commented on HBASE-23355: -------------------------------- So here we should ignore the flush and compaction case when do prefetch, an= d only consider open and bulkload?=20 > Add=C2=A0a conf key to decide which operations can trigger prefetch > -------------------------------------------------------------- > > Key: HBASE-23355 > URL: https://issues.apache.org/jira/browse/HBASE-23355 > Project: HBase > Issue Type: Improvement > Reporter: chenxu > Assignee: chenxu > Priority: Major > > Copy the comment from=C2=A0anoop under https://issues.apache.org/jira/bro= wse/HBASE-23066?focusedCommentId=3D16984140&page=3Dcom.atlassian.jira.plugi= n.system.issuetabpanels%3Acomment-tabpanel#comment-16984140 > {quote}On a side note, (Not related to this issue) when we have cache on = write ON as well as prefetch also On, do we do the caching part for the flu= shed files twice? When it is written, its already been added to cache. Late= r as part of HFile reader open, the prefetch threads will again do a read a= nd add to cache! > {quote} > It's better to have a conf key to decide which operations(flush, compacti= on, regionOpen, bulkload) can trigger the prefetch. In this way, if cacheon= write is enabled, we can exclude the flush and compaction operations when d= oing prefetch. -- This message was sent by Atlassian Jira (v8.3.4#803005)