hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "HBase QA (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter
Date Tue, 03 Dec 2019 01:50:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986505#comment-16986505
] 

HBase QA commented on HBASE-23309:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 27s{color} | {color:blue}
Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  0s{color} |
{color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  0s{color}
| {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 49s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 56s{color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 30s{color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m  0s{color}
| {color:green} branch has no errors when building our shaded downstream artifacts. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 38s{color} |
{color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  4m 36s{color} | {color:blue}
Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 35s{color} |
{color:green} master passed {color} |
| {color:orange}-0{color} | {color:orange} patch {color} | {color:orange}  4m 43s{color} |
{color:orange} Used diff version of patch file. Binary files and potentially other changes
not applied. Please rebase and squash commits if necessary. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 23s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 56s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 56s{color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 29s{color} | {color:red}
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color}
|
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 59s{color}
| {color:green} patch has no errors when building our shaded downstream artifacts. {color}
|
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 17m  6s{color}
| {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color}
|
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 37s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 36s{color} |
{color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}162m 17s{color} | {color:green}
hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 26s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}223m 33s{color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-837/6/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/837 |
| JIRA Issue | HBASE-23309 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 80d6c2f2ae21 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019
x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-837/out/precommit/personality/provided.sh
|
| git revision | master / 97e0107000 |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-837/6/artifact/out/diff-checkstyle-hbase-server.txt
|
|  Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-837/6/testReport/
|
| Max. process+thread count | 4578 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-837/6/console
|
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |


This message was automatically generated.



> Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through
WalCellFilter
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-23309
>                 URL: https://issues.apache.org/jira/browse/HBASE-23309
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 1.3.6, 2.3.3
>            Reporter: Sandeep Pal
>            Assignee: Sandeep Pal
>            Priority: Major
>         Attachments: HBASE-23309.branch-1.patch, HBASE-23309.branch-2.patch, HBASE-23309.patch
>
>
> ChainWalEntryFilter applies the filter on entry followed by filter on cells. 
>  If filter on cells remove all the cells from the entry, we should add an option in chainwalentryfilter
to filter the entry as well. 
> Here is the snippet for ChainWalEntryFilter filter. After filterCells we should check
if there is any cells remaining in the entry. 
> {code:java}
> @Override
> public Entry filter(Entry entry) {
>  for (WALEntryFilter filter : filters) {
>  if (entry == null) {
>  return null;
>  }
>  entry = filter.filter(entry);
>  }
>  filterCells(entry);
>  return entry;
> }{code}
>  Customer replication endpoints may use this flag.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message