Return-Path: Delivered-To: apmail-hadoop-hbase-commits-archive@locus.apache.org Received: (qmail 92726 invoked from network); 19 Jan 2009 21:22:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Jan 2009 21:22:04 -0000 Received: (qmail 90235 invoked by uid 500); 19 Jan 2009 21:22:04 -0000 Delivered-To: apmail-hadoop-hbase-commits-archive@hadoop.apache.org Received: (qmail 90213 invoked by uid 500); 19 Jan 2009 21:22:04 -0000 Mailing-List: contact hbase-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-commits@hadoop.apache.org Received: (qmail 90204 invoked by uid 99); 19 Jan 2009 21:22:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jan 2009 13:22:04 -0800 X-ASF-Spam-Status: No, hits=-1996.5 required=10.0 tests=ALL_TRUSTED,URIBL_BLACK X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jan 2009 21:21:52 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 221E123888AF; Mon, 19 Jan 2009 13:21:31 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r735825 - in /hadoop/hbase/trunk: CHANGES.txt build.xml src/java/org/onelab/filter/HashFunction.java Date: Mon, 19 Jan 2009 21:21:30 -0000 To: hbase-commits@hadoop.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090119212131.221E123888AF@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stack Date: Mon Jan 19 13:21:30 2009 New Revision: 735825 URL: http://svn.apache.org/viewvc?rev=735825&view=rev Log: HBASE-1136 HashFunction inadvertently destroys some randomness Modified: hadoop/hbase/trunk/CHANGES.txt hadoop/hbase/trunk/build.xml hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java Modified: hadoop/hbase/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=735825&r1=735824&r2=735825&view=diff ============================================================================== --- hadoop/hbase/trunk/CHANGES.txt (original) +++ hadoop/hbase/trunk/CHANGES.txt Mon Jan 19 13:21:30 2009 @@ -1,4 +1,10 @@ HBase Change Log +Release 0.20.0 - Unreleased + INCOMPATIBLE CHANGES + + BUG FIXES + HBASE-1136 HashFunction inadvertently destroys some randomness + Release 0.19.0 - Unreleased INCOMPATIBLE CHANGES HBASE-885 TableMap and TableReduce should be interfaces Modified: hadoop/hbase/trunk/build.xml URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/build.xml?rev=735825&r1=735824&r2=735825&view=diff ============================================================================== --- hadoop/hbase/trunk/build.xml (original) +++ hadoop/hbase/trunk/build.xml Mon Jan 19 13:21:30 2009 @@ -18,7 +18,7 @@ --> - + Modified: hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java?rev=735825&r1=735824&r2=735825&view=diff ============================================================================== --- hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java (original) +++ hadoop/hbase/trunk/src/java/org/onelab/filter/HashFunction.java Mon Jan 19 13:21:30 2009 @@ -118,7 +118,8 @@ } int[] result = new int[nbHash]; for (int i = 0, initval = 0; i < nbHash; i++) { - initval = result[i] = Math.abs(hashFunction.hash(b, initval) % maxValue); + initval = hashFunction.hash(b, initval); + result[i] = Math.abs(initval) % maxValue; } return result; }//end hash()