Return-Path: Delivered-To: apmail-hadoop-hbase-commits-archive@locus.apache.org Received: (qmail 30672 invoked from network); 18 Jan 2009 22:04:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Jan 2009 22:04:48 -0000 Received: (qmail 15551 invoked by uid 500); 18 Jan 2009 22:04:47 -0000 Delivered-To: apmail-hadoop-hbase-commits-archive@hadoop.apache.org Received: (qmail 15532 invoked by uid 500); 18 Jan 2009 22:04:47 -0000 Mailing-List: contact hbase-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-commits@hadoop.apache.org Received: (qmail 15522 invoked by uid 99); 18 Jan 2009 22:04:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jan 2009 14:04:47 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jan 2009 22:04:45 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 80E602388988; Sun, 18 Jan 2009 14:04:24 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r735555 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java Date: Sun, 18 Jan 2009 22:04:24 -0000 To: hbase-commits@hadoop.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090118220424.80E602388988@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stack Date: Sun Jan 18 14:04:24 2009 New Revision: 735555 URL: http://svn.apache.org/viewvc?rev=735555&view=rev Log: HBASE-1132 Can't append to HLog, can't roll log, infinite cycle (another spin on HBASE-930) Modified: hadoop/hbase/trunk/CHANGES.txt hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java Modified: hadoop/hbase/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=735555&r1=735554&r2=735555&view=diff ============================================================================== --- hadoop/hbase/trunk/CHANGES.txt (original) +++ hadoop/hbase/trunk/CHANGES.txt Sun Jan 18 14:04:24 2009 @@ -145,6 +145,8 @@ not already marked as pending close HBASE-1124 Balancer kicks in way too early HBASE-1127 OOME running randomRead PE + HBASE-1132 Can't append to HLog, can't roll log, infinite cycle (another + spin on HBASE-930) IMPROVEMENTS HBASE-901 Add a limit to key length, check key and value length on client side Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java?rev=735555&r1=735554&r2=735555&view=diff ============================================================================== --- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java (original) +++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/regionserver/LogRoller.java Sun Jan 18 14:04:24 2009 @@ -68,14 +68,18 @@ } } catch (FailedLogCloseException e) { LOG.fatal("Forcing server shutdown", e); + server.checkFileSystem(); server.abort(); } catch (java.net.ConnectException e) { LOG.fatal("Forcing server shutdown", e); + server.checkFileSystem(); server.abort(); } catch (IOException ex) { - LOG.error("Log rolling failed with ioe: ", - RemoteExceptionHandler.checkIOException(ex)); + LOG.fatal("Log rolling failed with ioe: ", + RemoteExceptionHandler.checkIOException(ex)); server.checkFileSystem(); + // Abort if we get here. We probably won't recover an IOE. HBASE-1132 + server.abort(); } catch (Exception ex) { LOG.error("Log rolling failed", ex); server.checkFileSystem(); @@ -123,4 +127,4 @@ rollLock.unlock(); } } -} \ No newline at end of file +}