Return-Path: Delivered-To: apmail-hadoop-hbase-commits-archive@locus.apache.org Received: (qmail 21736 invoked from network); 13 Jan 2009 05:59:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Jan 2009 05:59:21 -0000 Received: (qmail 49840 invoked by uid 500); 13 Jan 2009 05:59:21 -0000 Delivered-To: apmail-hadoop-hbase-commits-archive@hadoop.apache.org Received: (qmail 49824 invoked by uid 500); 13 Jan 2009 05:59:21 -0000 Mailing-List: contact hbase-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-commits@hadoop.apache.org Received: (qmail 49815 invoked by uid 99); 13 Jan 2009 05:59:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jan 2009 21:59:21 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2009 05:59:14 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 5853B2388920; Mon, 12 Jan 2009 21:58:54 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r734047 - in /hadoop/hbase/trunk: CHANGES.txt src/java/org/apache/hadoop/hbase/client/HConnectionManager.java Date: Tue, 13 Jan 2009 05:58:53 -0000 To: hbase-commits@hadoop.apache.org From: stack@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090113055854.5853B2388920@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: stack Date: Mon Jan 12 21:58:51 2009 New Revision: 734047 URL: http://svn.apache.org/viewvc?rev=734047&view=rev Log: HBASE-1121 Cluster confused about where -ROOT- is; commit better logging Modified: hadoop/hbase/trunk/CHANGES.txt hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java Modified: hadoop/hbase/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/CHANGES.txt?rev=734047&r1=734046&r2=734047&view=diff ============================================================================== --- hadoop/hbase/trunk/CHANGES.txt (original) +++ hadoop/hbase/trunk/CHANGES.txt Mon Jan 12 21:58:51 2009 @@ -139,6 +139,7 @@ HBASE-1114 Weird NPEs compacting HBASE-1116 generated web.xml and svn don't play nice together HBASE-1119 ArrayOutOfBoundsException in HStore.compact + HBASE-1121 Cluster confused about where -ROOT- is IMPROVEMENTS HBASE-901 Add a limit to key length, check key and value length on client side Modified: hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java URL: http://svn.apache.org/viewvc/hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java?rev=734047&r1=734046&r2=734047&view=diff ============================================================================== --- hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java (original) +++ hadoop/hbase/trunk/src/java/org/apache/hadoop/hbase/client/HConnectionManager.java Mon Jan 12 21:58:51 2009 @@ -211,13 +211,13 @@ } } catch (IOException e) { - if(tries == numRetries - 1) { + if (tries == numRetries - 1) { // This was our last chance - don't bother sleeping break; } - LOG.info("Attempt " + tries + " of " + this.numRetries + - " failed with <" + e + ">. Retrying after sleep of " + - getPauseTime(tries)); + LOG.info("getMaster attempt " + tries + " of " + this.numRetries + + " failed; retrying after sleep of " + + getPauseTime(tries), e); } // Cannot connect to master or it is not running. Sleep & retry @@ -550,9 +550,9 @@ } if (tries < numRetries - 1) { if (LOG.isDebugEnabled()) { - LOG.debug("Attempt " + tries + " of " + this.numRetries + - " failed with <" + e + ">. Retrying after sleep of " + - getPauseTime(tries)); + LOG.debug("locateRegionInMeta attempt " + tries + " of " + + this.numRetries + " failed; retrying after sleep of " + + getPauseTime(tries), e); } relocateRegion(parentTable, metaKey); } else { @@ -747,7 +747,6 @@ HServerAddress rootRegionAddress = null; for (int tries = 0; tries < numRetries; tries++) { int localTimeouts = 0; - // ask the master which server has the root region while (rootRegionAddress == null && localTimeouts < numRetries) { rootRegionAddress = master.findRootRegion(); @@ -772,13 +771,13 @@ // get a connection to the region server HRegionInterface server = getHRegionConnection(rootRegionAddress); - try { // if this works, then we're good, and we have an acceptable address, // so we can stop doing retries and return the result. server.getRegionInfo(HRegionInfo.ROOT_REGIONINFO.getRegionName()); if (LOG.isDebugEnabled()) { - LOG.debug("Found ROOT " + HRegionInfo.ROOT_REGIONINFO); + LOG.debug("Found ROOT at " + rootRegionAddress + + " (server=" + server + ")"); } break; } catch (IOException e) { @@ -875,7 +874,8 @@ private HRegionLocation getRegionLocationForRowWithRetries(byte[] tableName, byte[] rowKey, - boolean reload) throws IOException { + boolean reload) + throws IOException { getMaster(); List exceptions = new ArrayList(); HRegionLocation location = null;