From yarn-issues-return-144365-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue May 8 01:39:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 16494180648 for ; Tue, 8 May 2018 01:39:03 +0200 (CEST) Received: (qmail 42516 invoked by uid 500); 7 May 2018 23:39:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 42505 invoked by uid 99); 7 May 2018 23:39:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 May 2018 23:39:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 896EBCAA10 for ; Mon, 7 May 2018 23:39:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jedp2MMYK6VR for ; Mon, 7 May 2018 23:39:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 369475F485 for ; Mon, 7 May 2018 23:39:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 720C5E0047 for ; Mon, 7 May 2018 23:39:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3A6472129D for ; Mon, 7 May 2018 23:39:00 +0000 (UTC) Date: Mon, 7 May 2018 23:39:00 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7892) Revisit NodeAttribute class structure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7892?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16466= 618#comment-16466618 ]=20 Wangda Tan commented on YARN-7892: ---------------------------------- Thanks [~Naganarasimha], For id(identifier) and key, I think they're interc= hangeable in many scenarios such as entity.id / entity.key.=C2=A0 However, for the map-like data (1 =3D> 1 mapping), for example map / enviro= nment-variable, etc. The it should be named as "key" instead of "id", you c= an check {{org.apache.hadoop.yarn.api.resource.PlacementConstraint.TargetEx= pression}} as an example. > Revisit NodeAttribute class structure > ------------------------------------- > > Key: YARN-7892 > URL: https://issues.apache.org/jira/browse/YARN-7892 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Major > Attachments: YARN-7892-YARN-3409.001.patch, YARN-7892-YARN-3409.0= 02.patch, YARN-7892-YARN-3409.003.WIP.patch, YARN-7892-YARN-3409.003.patch,= YARN-7892-YARN-3409.004.patch, YARN-7892-YARN-3409.005.patch, YARN-7892-YA= RN-3409.006.patch > > > In the existing structure, we had kept the type and value along with the = attribute which would create confusion to the user to understand the APIs a= s they would not be clear as to what needs to be sent for type and value wh= ile fetching the mappings for node(s). > As well as equals will not make sense when we compare only for prefix and= name where as values for them might be different.=C2=A0=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org