hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith Sharma K S (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7933) [atsv2 read acls] Add TimelineWriter#writeDomain
Date Thu, 03 May 2018 17:20:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462813#comment-16462813
] 

Rohith Sharma K S commented on YARN-7933:
-----------------------------------------

{quote} Does the patch require a domain id for every timelineEntity? Or what happens if no
domain id set?
{quote}
This patch is only for storing domain entity into table. For storing in TimelineEntity, we
should discuss it separately because we are still not decided that should we store TimelineDomain
as denormalized form or just domain id in entity table.
{quote}The /domain endpoint takes appId as a query param. Is it the same as the app id in
the TimelineCollector context?
{quote}
Yes, it should be same as TimelineCollector context only. TimelineV2Client#putDomain is still
with in the scope of appId.
{quote}Does it make sense in this patch to add in memory cache of domain in TimelineCollector?
Given the patch deals with the write path, probably so.
{quote}
As I mentioned in 1st reply, we need to discuss and get conses how are we going to store timelineDomain
in entity table. There are both pros and cons are there. So I restricted this patch only to
store timelineDomain. I guess there is separate JIRA for cache implementation.
{quote}In HBaseTimelineWriterImpl, null-checking is done solely for clusterId. Do we need
to check for domainId as well?
{quote}
This could be done. I assumed that domainId will not be empty. Similar to entityId in TimelineEntity
class.

> [atsv2 read acls] Add TimelineWriter#writeDomain 
> -------------------------------------------------
>
>                 Key: YARN-7933
>                 URL: https://issues.apache.org/jira/browse/YARN-7933
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vrushali C
>            Assignee: Rohith Sharma K S
>            Priority: Major
>         Attachments: YARN-7933.01.patch, YARN-7933.02.patch, YARN-7933.03.patch, YARN-7933.04.patch
>
>
>  
> Add an API TimelineWriter#writeDomain for writing the domain info 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message