Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 1 Feb 2017 18:09:51 +0000 (UTC)
From: "Daniel Templeton (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <JIRA.13024645.1480559972000.9555.1485972591677@Atlassian.JIRA>
In-Reply-To: <JIRA.13024645.1480559972000@Atlassian.JIRA>
References: <JIRA.13024645.1480559972000@Atlassian.JIRA> <JIRA.13024645.1480559972153@jira-lw-us.apache.org>
Subject: [jira] [Commented] (YARN-5946) Create YarnConfigurationStore class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 01 Feb 2017 18:09:56 -0000


    [ https://issues.apache.org/jira/browse/YARN-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848724#comment-15848724 ] 

Daniel Templeton commented on YARN-5946:
----------------------------------------

Thanks, [~jhung].  I have a few comments.

First, on the pedantic side, you're missing parameter descriptions in the {{initialize()}} and {{logMutations()}} javadocs, and you're missing the {{LogItem}} javadocs altogether.  {{readPersistedId()}} returns the oldest change that hasn't been persisted--maybe call it {{getNextIdToPersist()}}?  {{retrieve()}} returns a map of strings, but wouldn't it be more useful to return a {{Configuration}}?

At a higher level, I don't quite get this interface.  According to the diagrams on YARN-5734, all access to the conf store will go through the {{MutableConfigurationManager}}.  That means that the MCM will be the one that's calling the retrieve/store half of the API and also be the one calling the WAL part of the API.  If that's the case, why do you need both in the interface?  Seems like the MCM should be able to handle validating the changes before storing them.

> Create YarnConfigurationStore class
> -----------------------------------
>
>                 Key: YARN-5946
>                 URL: https://issues.apache.org/jira/browse/YARN-5946
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jonathan Hung
>            Assignee: Jonathan Hung
>         Attachments: YARN-5946.001.patch, YARN-5946-YARN-5734.002.patch
>
>
> This class provides the interface to persist YARN configurations in a backing store.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org