Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: yarn-issues@hadoop.apache.org
Date: Thu, 1 Nov 2012 16:49:15 +0000 (UTC)
From: "Robert Joseph Evans (JIRA)" <jira@apache.org>
To: yarn-issues@hadoop.apache.org
Message-ID: <1607029712.56692.1351788555350.JavaMail.jiratomcat@arcas>
In-Reply-To: <852804887.38041.1351489513269.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (YARN-188) Coverage fixing for CapacityScheduler
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/YARN-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488820#comment-13488820 ] 

Robert Joseph Evans commented on YARN-188:
------------------------------------------

The tests themselves look good.  My only comment is that I would like to see this combined with TestCapacityScheduler.java.  There is no need to have two classes to test the same thing.  Also you only need to upload a single patch if they apply to all of the other branches. 
                
> Coverage fixing for CapacityScheduler
> -------------------------------------
>
>                 Key: YARN-188
>                 URL: https://issues.apache.org/jira/browse/YARN-188
>             Project: Hadoop YARN
>          Issue Type: Test
>          Components: capacityscheduler
>            Reporter: Aleksey Gorshkov
>         Attachments: YARN-188-branch-0.23.patch, YARN-188-branch-2.patch, YARN-188-trunk.patch
>
>
> some tests for CapacityScheduler
> YARN-188-branch-0.23.patch patch for branch 0.23
> YARN-188-branch-2.patch patch for branch 2
> YARN-188-trunk.patch  patch for trunk

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira