Return-Path: 
 <mapreduce-issues-return-83838-apmail-hadoop-mapreduce-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 242D318C3B
	for <apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org>;
 Tue,  2 Feb 2016 06:21:40 +0000 (UTC)
Received: (qmail 42355 invoked by uid 500); 2 Feb 2016 06:21:40 -0000
Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org
Received: (qmail 42292 invoked by uid 500); 2 Feb 2016 06:21:39 -0000
Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mapreduce-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:mapreduce-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:mapreduce-issues@hadoop.apache.org>
List-Id: <mapreduce-issues.hadoop.apache.org>
Reply-To: mapreduce-issues@hadoop.apache.org
Delivered-To: mailing list mapreduce-issues@hadoop.apache.org
Received: (qmail 42280 invoked by uid 99); 2 Feb 2016 06:21:39 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2016 06:21:39 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id C411D2C1F57
	for <mapreduce-issues@hadoop.apache.org>;
 Tue,  2 Feb 2016 06:21:39 +0000 (UTC)
Date: Tue, 2 Feb 2016 06:21:39 +0000 (UTC)
From: "Xuan Gong (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12934981.1454032046000.273535.1454394099800@Atlassian.JIRA>
In-Reply-To: <JIRA.12934981.1454032046000@Atlassian.JIRA>
References: <JIRA.12934981.1454032046000@Atlassian.JIRA>
 <JIRA.12934981.1454032046323@arcas>
Subject: [jira] [Commented] (MAPREDUCE-6621) Memory Leak in
 JobClient#submitJobInternal()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/MAPREDUCE-6621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127745#comment-15127745 ] 

Xuan Gong commented on MAPREDUCE-6621:
--------------------------------------

Thanks for the comments. [~jlowe]

Attached a new patch to address the comments.

> Memory Leak in JobClient#submitJobInternal()
> --------------------------------------------
>
>                 Key: MAPREDUCE-6621
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6621
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: MAPREDUCE-6621.1.patch, MAPREDUCE-6621.2.patch
>
>
> In JobClient:
> {code}
> public RunningJob submitJobInternal(final JobConf conf)
>       throws FileNotFoundException, IOException {
>     try {
>       conf.setBooleanIfUnset("mapred.mapper.new-api", false);
>       conf.setBooleanIfUnset("mapred.reducer.new-api", false);
>       Job job = clientUgi.doAs(new PrivilegedExceptionAction<Job> () {
>         @Override
>         public Job run() throws IOException, ClassNotFoundException, 
>           InterruptedException {
>           Job job = Job.getInstance(conf);
>           job.submit();
>           return job;
>         }
>       });
>       // update our Cluster instance with the one created by Job for submission
>       // (we can't pass our Cluster instance to Job, since Job wraps the config
>       // instance, and the two configs would then diverge)
>       cluster = job.getCluster();
>       return new NetworkedJob(job);
>     } catch (InterruptedException ie) {
>       throw new IOException("interrupted", ie);
>     }
>   }
> {code}
> We will replace the cluster object with the cluster object from Job, but the previous old cluster object would never be closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)