Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 94905 invoked from network); 1 Jul 2009 18:36:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Jul 2009 18:36:00 -0000 Received: (qmail 9914 invoked by uid 500); 1 Jul 2009 18:36:10 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 9885 invoked by uid 500); 1 Jul 2009 18:36:10 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 9874 invoked by uid 99); 1 Jul 2009 18:36:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2009 18:36:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2009 18:36:08 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C1A3D234C045 for ; Wed, 1 Jul 2009 11:35:48 -0700 (PDT) Message-ID: <585007306.1246473348792.JavaMail.jira@brutus> Date: Wed, 1 Jul 2009 11:35:48 -0700 (PDT) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-456) Problems with dfs.name.edits.dirs as URI MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726173#action_12726173 ] Tsz Wo (Nicholas), SZE commented on HDFS-456: --------------------------------------------- > ... we need treat windows paths specially.. something like what firefox does ("c:/" in url bar is an error, but "c:\" gets mapped to "file:///c:/"). +1 I think converting Windows path c:\foo to URI file:///c:/foo is a standard but not specific to firefox. BTW, since we assume Cygwin in Windows, could we just use /cygdrive/c/foo? > Problems with dfs.name.edits.dirs as URI > ---------------------------------------- > > Key: HDFS-456 > URL: https://issues.apache.org/jira/browse/HDFS-456 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.21.0 > Reporter: Konstantin Shvachko > Assignee: Luca Telloli > Fix For: 0.21.0 > > > There are several problems with recent commit of HDFS-396. > # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}. > # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI. Backward compatibility is not provided. > # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a {{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed in another jira. > # Why do we commit patches without running unit tests and test-patch? This is the minimum requirement for a patch to qualify as committable, right? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.