Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <251919992.1247304314792.JavaMail.jira@brutus>
Date: Sat, 11 Jul 2009 02:25:14 -0700 (PDT)
From: "Luca Telloli (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-397) Incorporate storage directories into
 EditLogFileInput/Output streams
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729964#action_12729964 ] 

Luca Telloli commented on HDFS-397:
-----------------------------------

Raghu

1. the second piece of code is correct (at least for the purpose of the patch)
The first piece of code I guess should be also correct due to a name clash since 
{noformat}
private static final String STORAGE_JSPOOL_FILE = 
                                              NameNodeFile.EDITS_NEW.getName();
{noformat}

I assumed it's correct since it passed the unit tests correctly. 

2. in HDFS-311, for instance every time a constructor for a Input/Output stream is called, this patch matters. 
Have a look for instance to line 1497 and following. 

Finally, I think one advantage of this patch is that I achieve to avoid calling unnecessary constructors for Input/Output streams, 
which in previous code belonged to the necessity of strictly keeping the order of streams and the order of storage directories in sync. 


> Incorporate storage directories into EditLogFileInput/Output streams
> --------------------------------------------------------------------
>
>                 Key: HDFS-397
>                 URL: https://issues.apache.org/jira/browse/HDFS-397
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Luca Telloli
>            Assignee: Luca Telloli
>         Attachments: HADOOP-6001.patch, HADOOP-6001.patch, HADOOP-6001.patch, HDFS-397.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.