From hdfs-dev-return-40853-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jan 13 13:24:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2C82818064E for ; Mon, 13 Jan 2020 14:24:07 +0100 (CET) Received: (qmail 21684 invoked by uid 500); 13 Jan 2020 13:24:05 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 21670 invoked by uid 99); 13 Jan 2020 13:24:05 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Jan 2020 13:24:05 +0000 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id E97B71079 for ; Mon, 13 Jan 2020 13:24:04 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id r14so6856729lfm.5 for ; Mon, 13 Jan 2020 05:24:04 -0800 (PST) X-Gm-Message-State: APjAAAWQ2ofQEXX5SglwqwCYxwsV3R+Di630Do00h62OXYfqU2GoC7dg uYG2s3cFDFrc6k4RVAIpfbYG9E3pPmTDuGlym0FXVg== X-Google-Smtp-Source: APXvYqzHBMtjLUlS+a4UxHJnXbHfppeNy0naXURZ74/9QvM+WXVxsfx/dZMKIZL+nQWMB9zrHwV5ZR+BwMANhZWWDE0= X-Received: by 2002:ac2:4a91:: with SMTP id l17mr9631701lfp.75.1578921843774; Mon, 13 Jan 2020 05:24:03 -0800 (PST) MIME-Version: 1.0 References: <1968798093.10688734.1578591207636.ref@mail.yahoo.com> <1968798093.10688734.1578591207636@mail.yahoo.com> In-Reply-To: <1968798093.10688734.1578591207636@mail.yahoo.com> From: Wei-Chiu Chuang Date: Mon, 13 Jan 2020 05:23:37 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [DISCUSS] Guidelines for Code cleanup JIRAs To: "epayne@apache.org" Cc: Yarn-dev , Hdfs-dev , Hadoop Common Content-Type: multipart/alternative; boundary="000000000000a082ce059c056393" --000000000000a082ce059c056393 Content-Type: text/plain; charset="UTF-8" +1 On Thu, Jan 9, 2020 at 9:33 AM epayne@apache.org wrote: > There was some discussion on > https://issues.apache.org/jira/browse/YARN-9052 > about concerns surrounding the costs/benefits of code cleanup JIRAs. This > email > is to get the discussion going within a wider audience. > > The positive points for code cleanup JIRAs: > - Clean up tech debt > - Make code more readable > - Make code more maintainable > - Make code more performant > > The concerns regarding code cleanup JIRAs are as follows: > - If the changes only go into trunk, then contributors and committers > trying to > backport to prior releases will have to create and test multiple patch > versions. > - Some have voiced concerns that code cleanup JIRAs may not be tested as > thoroughly as features and bug fixes because functionality is not > supposed to > change. > - Any patches awaiting review that are touching the same code will have to > be > redone, re-tested, and re-reviewed. > - JIRAs that are opened for code cleanup and not worked on right away tend > to > clutter up the JIRA space. > > Here are my opinions: > - Code changes of any kind force a non-trivial amount of overhead for other > developers. For code cleanup JIRAs, sometimes the usability, > maintainability, > and performance is worth the overhead (as in the case of YARN-9052). > - Before opening any JIRA, please always consider whether or not the added > usability will outweigh the added pain you are causing other developers. > - If you believe the benefits outweigh the costs, please backport the > changes > yourself to all active lines. My preference is to port all the way back > to 2.10. > - Please don't run code analysis tools and then open many JIRAs that > document > those findings. That activity does not put any thought into this > cost-benefit > analysis. > > Thanks everyone. I'm looking forward to your thoughts. I appreciate all > you do > for the open source community and it is always a pleasure to work with you. > -Eric Payne > > --------------------------------------------------------------------- > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org > > --000000000000a082ce059c056393--