From hdfs-dev-return-40832-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Jan 9 17:33:44 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 02A0818063F for ; Thu, 9 Jan 2020 18:33:43 +0100 (CET) Received: (qmail 58388 invoked by uid 500); 9 Jan 2020 17:33:42 -0000 Mailing-List: contact hdfs-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list hdfs-dev@hadoop.apache.org Received: (qmail 58369 invoked by uid 99); 9 Jan 2020 17:33:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jan 2020 17:33:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 17112C0274 for ; Thu, 9 Jan 2020 17:33:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.973 X-Spam-Level: X-Spam-Status: No, score=0.973 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.972] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id JZ2a57CmmmbL for ; Thu, 9 Jan 2020 17:33:39 +0000 (UTC) Received-SPF: Softfail (mailfrom) identity=mailfrom; client-ip=98.137.69.147; helo=sonic310-21.consmr.mail.gq1.yahoo.com; envelope-from=epayne@apache.org; receiver= Received: from sonic310-21.consmr.mail.gq1.yahoo.com (sonic310-21.consmr.mail.gq1.yahoo.com [98.137.69.147]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 05F0DBC564 for ; Thu, 9 Jan 2020 17:33:38 +0000 (UTC) X-ASF-DKIM-Sig: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1578591212; bh=WKv16ItWIJdlxiuKyHKOmNjLftISD3GYhU2GLlY09c8=; h=Date:From:To:Subject:References:From:Subject; b=k7HLwop3MvlwOCVI0tT4U/T1Lg4+/sT8eTMoM5y+xcDfQikzNghKN1FVeuMuUx9pLOzLKzTHt8Ny6OVDEemZd/GL8YgP55RLp6rJfG0qInG+Kw3PbsWnjBkmRVJRk2kfY+giAcKZ2SuhuBwZtNE6LsKk93mTw+HmkkN/6nA9gkk/S/zABQ2QihgrGI+qoyBsJG8SXpNk3bDMMKYU5xDLiDwr/ulSEM5QO9REGCY4xt2cDEVgAr7h0uGdLAtVLb4gTaq9vF5JaG80vnkDQpTyzP0tHj9Lr0pk+IQfVlO0PcM53yhGqueWy/ZYFDl4LWMwiqFknqdL7dKjbdZxGBdsdQ== X-YMail-OSG: ER.ReZAVM1ky7mi0H5bXyx8S6H4yY81IGA4RFMVbv_vLXpRRYwQioaH9IT1xfV2 hI3NWZg7fNHDNomP_zJU2PNTE5zLu1bVge.6MZQpqMJPo_zksjMicGbfNKdbSkqCn2F541A.74dL _Z2gH1zA1zSwIzgDqIq.WqGXhZkW1_RegnPsic09R.EFpLCuVX0mObSnYqJumNqXJ84sd1GiOdLg VssK7wwPoTrDrFO68sz5Ay7llRBIfif.h8caZjbT_Qhnqln4Uyett2XN7xfAYJh35kaRnppCXcUt lmg0ZUsEf8GsycrWay_bMGtBfwyRn3oxS0Vbth1md_PyUep3PvAs0TBROchJL5gwcZx9.VO84vsH i7P8VqYtpBHMPI2boDLE83O24X604G8S_q0iUcIbf5Q4PA9ndgktfLSM4QJBjV5Uy7fDhLGQbZ4D uiHCJj0Wg6vGVQhFTQeATjx2kW2sharOVD7Rj_HXgVWZEhlFFY0EedTteIzmoYC2Uykt5NAjKXs0 dAq.VesIQLq3skh87PSFPb1iX1uJVh5MrNhjkiWSsnNJ9xiUqFGZ7gjFtunAknlyG1p15.4X576d Kuw9TKbAxYeUzWlA4.8pZ_j0xfC1GBa51q1.fW9fkH.tPMFDVwYoisz3R2Iz.pi.5uwgCSTwBHtO 08WqJLBn758oE5YOa7QRod613O.MtgJIVpCH7G3T1F41nIwkTf.xrovvz6WpgQViUwOmdP1h8_fX 6NZwhf2EBd912kBXN9Q3ERg0OvHTjOLiUUJsera2qG.7xpRZhbKly9RF3WqfrlFuiO435Vt1mJ0f ydxfPaDksYAjWzFtnVXR.1_v_bHcyt5oxqeD_AZfbknqgE4GrdWj9DGpKIMjQ5HnxH.geVAvgJl. 7yknk69gRB.fHxXyQ3A1gDxeQw_sj1sB3TIoeqf2ZcebfvHyFydqvhwnB2s9WM8uwO.UAclS9yC3 bYOIUYzW87C5Miw_MUZbsoQjCq9BqmHdafqo17c9tfNFGuEQfvpNuq1RqO7SERWgWuaesUyWwQFN 8QAlDZloUl4gW6K2RjfrkR.O49JhQWkLv4qnArb1HUq7fw0OFev313Lz4ezGxSVOyv4vMsGhFZEx 6VXWQeQVySLCFgR.ELR5vLCBfh2ncQYxF77jpfm7SwJ7f0TjCXpBHsNrefkOgVD8KnUCqMGBWvDa Pq4_mS0Ypk4wVHBgUvfsRXJZ.tb.mL.5R37CQQE.owYaL3xFRpRR7lJkprkYyWpIWOxQtWAJYtjo AQK9YaFQKCdQL2jkXEusxmHxNMGd0RslHEvU_V05lDTk3faE1gFIx_y6k7GMtAgsto4J8TUDgfl2 KFSaj9usqZ2VEQuCOylTJfRnqJOpaftzxw7hJKwvGR7yI_We0 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Thu, 9 Jan 2020 17:33:32 +0000 Date: Thu, 9 Jan 2020 17:33:27 +0000 (UTC) From: "epayne@apache.org" To: Yarn-dev , Hdfs-dev , Hadoop Common Message-ID: <1968798093.10688734.1578591207636@mail.yahoo.com> Subject: [DISCUSS] Guidelines for Code cleanup JIRAs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable References: <1968798093.10688734.1578591207636.ref@mail.yahoo.com> X-Mailer: WebService/1.1.14873 YMailNorrin Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:71.0) Gecko/20100101 Firefox/71.0 There was some discussion on https://issues.apache.org/jira/browse/YARN-905= 2 about concerns surrounding the costs/benefits of code cleanup JIRAs. This e= mail is to get the discussion going within a wider audience. The positive points for code cleanup JIRAs: - Clean up tech debt - Make code more readable - Make code more maintainable - Make code more performant The concerns regarding code cleanup JIRAs are as follows: - If the changes only go into trunk, then contributors and committers tryin= g to =C2=A0backport to prior releases will have to create and test multiple patc= h versions. - Some have voiced concerns that code cleanup JIRAs may not be tested as =C2=A0 thoroughly as features and bug fixes because functionality is not su= pposed to =C2=A0 change. - Any patches awaiting review that are touching the same code will have to = be =C2=A0 redone, re-tested, and re-reviewed. - JIRAs that are opened for code cleanup and not worked on right away tend = to =C2=A0 clutter up the JIRA space. Here are my opinions: - Code changes of any kind force a non-trivial amount of overhead for other =C2=A0 developers. For code cleanup JIRAs, sometimes the usability, maintai= nability, =C2=A0 and performance is worth the overhead (as in the case of YARN-9052). - Before opening any JIRA, please always consider whether or not the added =C2=A0 usability will outweigh the added pain you are causing other develop= ers. - If you believe the benefits outweigh the costs, please backport the chang= es =C2=A0 yourself to all active lines. My preference is to port all the way b= ack to 2.10. - Please don't run code analysis tools and then open many JIRAs that docume= nt =C2=A0 those findings. That activity does not put any thought into this cos= t-benefit =C2=A0 analysis. Thanks everyone. I'm looking forward to your thoughts. I appreciate all you= do for the open source community and it is always a pleasure to work with you. -Eric Payne --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org