Return-Path: Delivered-To: apmail-hadoop-common-commits-archive@www.apache.org Received: (qmail 16504 invoked from network); 6 Jan 2010 22:03:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 Jan 2010 22:03:55 -0000 Received: (qmail 63744 invoked by uid 500); 6 Jan 2010 22:03:55 -0000 Delivered-To: apmail-hadoop-common-commits-archive@hadoop.apache.org Received: (qmail 63665 invoked by uid 500); 6 Jan 2010 22:03:55 -0000 Mailing-List: contact common-commits-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-dev@hadoop.apache.org Delivered-To: mailing list common-commits@hadoop.apache.org Received: (qmail 63656 invoked by uid 99); 6 Jan 2010 22:03:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2010 22:03:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jan 2010 22:03:54 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 878F22388901; Wed, 6 Jan 2010 22:03:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r896691 - in /hadoop/common/trunk: CHANGES.txt src/test/core/org/apache/hadoop/io/TestUTF8.java Date: Wed, 06 Jan 2010 22:03:34 -0000 To: common-commits@hadoop.apache.org From: tomwhite@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100106220334.878F22388901@eris.apache.org> Author: tomwhite Date: Wed Jan 6 22:03:33 2010 New Revision: 896691 URL: http://svn.apache.org/viewvc?rev=896691&view=rev Log: HADOOP-6479. TestUTF8 assertions could fail with better text. Contributed by Steve Loughran. Modified: hadoop/common/trunk/CHANGES.txt hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java Modified: hadoop/common/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/hadoop/common/trunk/CHANGES.txt?rev=896691&r1=896690&r2=896691&view=diff ============================================================================== --- hadoop/common/trunk/CHANGES.txt (original) +++ hadoop/common/trunk/CHANGES.txt Wed Jan 6 22:03:33 2010 @@ -91,6 +91,9 @@ HADOOP-3205. Read multiple chunks directly from FSInputChecker subclass into user buffers. (Todd Lipcon via tomwhite) + HADOOP-6479. TestUTF8 assertions could fail with better text. + (Steve Loughran via tomwhite) + OPTIMIZATIONS BUG FIXES Modified: hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java URL: http://svn.apache.org/viewvc/hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java?rev=896691&r1=896690&r2=896691&view=diff ============================================================================== --- hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java (original) +++ hadoop/common/trunk/src/test/core/org/apache/hadoop/io/TestUTF8.java Wed Jan 6 22:03:33 2010 @@ -68,16 +68,16 @@ // test that it reads correctly in.reset(out.getData(), out.getLength()); String after = UTF8.readString(in); - assertTrue(before.equals(after)); + assertEquals(before, after); // test that it reads correctly with DataInput in.reset(out.getData(), out.getLength()); String after2 = in.readUTF(); - assertTrue(before.equals(after2)); + assertEquals(before, after2); // test that it is compatible with Java's other decoder String after3 = new String(out.getData(), 2, out.getLength()-2, "UTF-8"); - assertTrue(before.equals(after3)); + assertEquals(before, after3); }