Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4AC53200BDA for ; Tue, 13 Dec 2016 14:16:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 495DD160B23; Tue, 13 Dec 2016 13:16:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EE6E7160B15 for ; Tue, 13 Dec 2016 14:16:10 +0100 (CET) Received: (qmail 30142 invoked by uid 500); 13 Dec 2016 13:16:10 -0000 Mailing-List: contact users-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@groovy.apache.org Delivered-To: mailing list users@groovy.apache.org Received: (qmail 30132 invoked by uid 99); 13 Dec 2016 13:16:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Dec 2016 13:16:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 93BBDC0922 for ; Tue, 13 Dec 2016 13:16:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.38 X-Spam-Level: ** X-Spam-Status: No, score=2.38 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iCVD9LAQjOrK for ; Tue, 13 Dec 2016 13:16:07 +0000 (UTC) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 941E65F47A for ; Tue, 13 Dec 2016 13:16:06 +0000 (UTC) Received: by mail-wm0-f43.google.com with SMTP id f82so120262945wmf.1 for ; Tue, 13 Dec 2016 05:16:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=5T9PIxTmHjSuoagvBtbWF/VYEvAo915t+RMYh2gbDKI=; b=nIaBx9CKJTca6vWPjaIaor1VitKLdwqmTQsDO5+TJP7+LzMIOOnviOovtykT17AFLo U4TFyRyckvDOT7udh/YptLLnRgdhbvY2XgJY7tkfhwI2XjddvvRwtQAOoQmoVksHB2nV waOHyUtWwEgYIJlXHmys1bQZYwz3rcCCHOHwEG60Up35sFvkjeKMqUbOLk55E6HbeXrU A0vCI4ScuqQ6+KyMz5+5OflMdOj5R3Zgek3ZTA3cMvpPIrg9DgmSeo5gh+UHE7L5cuv3 GONBxnjdxEMMPkHYXqDoZ9QEmjqAV+6tZp4lFnnn8FcKWLGVldEm2MekCm/XhcrxJp3F TggQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=5T9PIxTmHjSuoagvBtbWF/VYEvAo915t+RMYh2gbDKI=; b=TirTkjO2fffgitazQTN85LpBKtHA/TXJ0f5a2qeRk4QhuBOf+zZLD6Gd1jLPH0OkCP daC5LMgvpkhnk9/O/bI+B6zDmDvpUFt/kytaq/FhAy8cdFfRNskl8yRtYfh5CictZmEA MX+Ft1SoSDig9VMOavfC3vznMAxhsCnOsWSDoNyjZhcz7xKvEgixIhtvoVkf6TRD/Xk7 pmud7J8SXnYiSfJ9da7fGSuzCPvNl4LrouRTDnnIBRH9Y6H+5LN72lo/skdKfqaSRflM slOkIXBIBv0Dy84+gtt64Kcp4UKvZwfua5iFKAdwXouuSzoM23YO2W0rF6Ah9gl1vmxh 8aaQ== X-Gm-Message-State: AKaTC01u1Rm4ebfuJ2ImiU6JT5Wrlj8qQcK5B7t6741VMNum41rJl8zcHtNl1OOu0q78nd3VBg57oam9MQ+flA== X-Received: by 10.25.212.82 with SMTP id l79mr2252206lfg.155.1481634965875; Tue, 13 Dec 2016 05:16:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.44.136 with HTTP; Tue, 13 Dec 2016 05:16:04 -0800 (PST) Received: by 10.25.44.136 with HTTP; Tue, 13 Dec 2016 05:16:04 -0800 (PST) In-Reply-To: References: From: Thibault Kruse Date: Tue, 13 Dec 2016 22:16:04 +0900 Message-ID: Subject: Re: Groovy Docker images To: users@groovy.apache.org Content-Type: multipart/alternative; boundary=001a11410f72d3f43d05438a057a archived-at: Tue, 13 Dec 2016 13:16:12 -0000 --001a11410f72d3f43d05438a057a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable By comments I mean what is in the readme. Dockerfiles get copy pasted without attached readme, so they should be self commenting. A minimalist server example may be nice. Can be in the same repo as a means of documentation, I think. For grapes I was worried about download location not writable. On Dec 11, 2016 19:12, "Keegan Witt" wrote: Thanks for the feedback, Thibault. I've responded in-line. - Might be better not to start groovysh, might be mentioned in Dockerfile comments instead - It's just a default to be run when the user does "docker run", they can specify an alternative command to run if they choose (see my grap= e example further down). Ruby, JRuby, and Python all do this, and it's mentioned in Docker's best practices . - Add Dockerfile comments, at least a link to the repo containing the dockerfiles - Did you mean a link to the Docker Hub page? If not, what comments do you think would be helpful in the Dockerfiles? - Add a LICENSE file to the github repo - Good catch. Done. - Add a travis job to the github repo that verifies the Dockerfiles - Yea, I intend to change the readme to link to the Docker Hub page (once published) and a Travis job, as you've suggested. Build automa= tion is something I have to work out yet, goes with the templating work I mentioned. - Provide one sample image on top of those images with some hello world application - Usage is pretty straightforward, but I could do that. It probably should be in a separate repo though, don't you think? Also any suggestions on a good sample? I was thinking something not compiled Groovy, beca= use for that you'd just run with Java Docker image, no need for Groovy on path. Maybe a script of some kind. - Check if grapes can be run from containers - Grape seemed to work, was there a particular problem you were concerned about? $ docker run -it --rm --name groovy groovy:jre8-latest Dec 11, 2016 9:37:40 AM java.util.prefs.FileSystemPreferences$1 run INFO: Created user preferences directory. Groovy Shell (2.4.7, JVM: 1.8.0_111) Type ':help' or ':h' for help. ------------------------------------------------------------ ------------------------------------------------------------ ------------------------------------------------------------ -------------------------- groovy:000> groovy.grape.Grape.grab(group:'org.springframework', module:'spring', version:'2.5.6') =3D=3D=3D> null $ docker run -it --rm --name groovy groovy:jre8-latest grape install 'org.springframework' 'spring' '2.5.6' :: loading settings :: url =3D jar:file:/opt/groovy/lib/ivy-2 .4.0.jar!/org/apache/ivy/core/settings/ivysettings.xml :: resolving dependencies :: caller#all-caller;working72 confs: [default] found org.springframework#spring;2.5.6 in jcenter found commons-logging#commons-logging;1.1.1 in jcenter downloading https://jcenter.bintray.com/org/springframework/spring/2.5. 6/spring-2.5.6.jar ... [SUCCESSFUL ] org.springframework#spring;2.5.6!spring.jar (2741ms) downloading https://jcenter.bintray.com/commons-logging/commons-logging/ 1.1.1/commons-logging-1.1.1.jar ... [SUCCESSFUL ] commons-logging#commons-logging;1.1.1!commons-logging= .jar (719ms) On Sun, Dec 11, 2016 at 3:32 AM, Thibault Kruse wrote: > Some minor comments: > - might be better not to start groovysh, might be mentioned in > Dockerfile comments instead > - Add Dockerfile comments, at least a link to the repo containing the > dockerfiles > - Add a LICENSE file to the github repo > - Add a travis job to the github repo that verifies the Dockerfiles > - check if grapes can be run from containers > - Provide one sample image on top of those images with some hello > world application > > > On Sun, Dec 11, 2016 at 3:24 PM, Keegan Witt wrote= : > > Sorry for the long turnaround on this. I've got some basic Dockerfiles > put > > together: https://github.com/keeganwitt/groovy-docker. Please let me > know > > what I can improve. One thing I might do is template out the Dockerfil= es > > similar to what Ruby did to make it easier to publish images when > there's a > > new Groovy version. > > > > I planned on creating both Alpine and non-Alpine images since that seem= s > to > > be the current practice. But we need to get GROOVY-7906 resolved for t= he > > Alpine images to work. > > > > I'm concerned about whether it'd be legal for us to distribute the Orac= le > > JDK with Groovy. I saw this article on the topic: > > http://blog.takipi.com/running-java-on-docker-youre-breaking-the-law/. > I > > don't speak legalize though. I haven't seen anyone else (Jruby, etc) > > publishing Oracle JDK, and Oracle has never published Docker images tha= t > > were not OpenJDK. The only images floating out there have been > > community-created. So for the time being, I don't plan to publish Orac= le > > based images. > > > > Once we think these look good, I'll move the repo over to groovy org in > > Github and we'll get them published to Docker Hub. Maybe we could also > ask > > Apache Infra to get them added to https://hub.docker.com/u/apache/, I > > haven't decided. What do you think? > > > > On Fri, Sep 9, 2016 at 11:19 PM, Corum, Michael > wrote: > >> > >> Not related to Groovy as much. We=E2=80=99ve never been able to get O= penJDK (7 > or > >> 8) to work properly with Oracle JDBC drivers on Alpine. Always have t= o > use > >> Oracle JDK and in the research we did, we found others with the same > issues. > >> > >> Michael Corum > >> > >> VP, Technical Architecture Solutions > >> > >> > >> > >> RGA Reinsurance Company > >> > >> 16600 Swingley Ridge Road > >> > >> Chesterfield, Missouri 6301701706 > >> > >> T 636.736.7066 > >> > >> www.rgare.com > >> > >> > >> > >> > >> From: Guillaume Laforge > >> Reply-To: "users@groovy.apache.org" > >> Date: Friday, September 9, 2016 at 10:16 PM > >> To: "users@groovy.apache.org" > >> Subject: Re: Groovy Docker images > >> > >> Out of curiosity, what's the problem with OpenJDK? > >> Is it related to Groovy or not at all? > >> > >> On Sat, Sep 10, 2016 at 5:09 AM, Corum, Michael > wrote: > >>> > >>> > >>> Either one > >>> Alpine =E2=80=93 I suspect others will want other options though > >>> Would most definitely prefer Oracle but I assume other would want > OpenJDK > >>> as well. For my purposes OpenJDK just doesn=E2=80=99t work at all. > >>> > >>> Michael Corum > >>> > >>> VP, Technical Architecture Solutions > >>> > >>> > >>> > >>> RGA Reinsurance Company > >>> > >>> 16600 Swingley Ridge Road > >>> > >>> Chesterfield, Missouri 6301701706 > >>> > >>> T 636.736.7066 > >>> > >>> www.rgare.com > >>> > >>> > >>> > >>> > >>> From: Keegan Witt > >>> Reply-To: "users@groovy.apache.org" > >>> Date: Friday, September 9, 2016 at 9:48 PM > >>> To: "users@groovy.apache.org" > >>> Subject: Groovy Docker images > >>> > >>> I was thinking of putting together some Docker images for Groovy, wit= h > >>> the idea they might be useful to base Grails, Gradle, etc images on a= nd > >>> wondered people's opinions on a few things. > >>> > >>> Should I install Groovy manually in somewhere like /opt? Or use > SDKMAN? > >>> Should I have images based on Alpine and Debian? Alpine only? > >>> I presume OpenJDK images are fine as bases? Any reason we'd need an > >>> Oracle based image too? > >>> > >>> Thoughts? > >>> > >>> -Keegan > >> > >> > >> > >> > >> -- > >> Guillaume Laforge > >> Apache Groovy committer & PMC Vice-President > >> Developer Advocate @ Google Cloud Platform > >> > >> Blog: http://glaforge.appspot.com/ > >> Social: @glaforge / Google+ > > > > > --001a11410f72d3f43d05438a057a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
By comments I mean what is in the readme. Dockerfiles get= copy pasted without attached readme, so they should be self commenting.
A minimalist server example may = be nice. Can be in the same repo as a means of documentation, I think.=C2= =A0

For grapes I was wor= ried about download location not writable.


On Dec 11, 2016 19:12, &= quot;Keegan Witt" <keeganwi= tt@gmail.com> wrote:
Thanks for the feedback, Thibault.=C2=A0 I'= ;ve responded in-line.
  • Might be better not to start groovysh, = might be mentioned in Dockerfile comments instead
    • It's = just a default to be run when the user does "docker run", they ca= n specify an alternative command to run if they choose (see my grape exampl= e further down).=C2=A0 Ruby, JRuby, and Python all do this, and it's me= ntioned in Docker's best practices= .
  • Add Dockerfile comments, at l= east a link to the repo containing the dockerfiles
    • Did yo= u mean a link to the Docker Hub page?=C2=A0 If not, what comments do you th= ink would be helpful in the Dockerfiles?
  • Add a LICENSE file to the github repo
    • Good catch.= =C2=A0 Done.
  • Add a travis job to th= e github repo that verifies the Dockerfiles
    • Yea, I intend= to change the readme to link to the Docker Hub page (once published) and a= Travis job, as you've suggested.=C2=A0 Build automation is something I= have to work out yet, goes with the templating work I mentioned.
      • <= /ul>
    • Provide one sample image on top of those= images with some hello world application
      • Usage is pr= etty straightforward, but I could do that.=C2=A0 It probably should be in a= separate repo though, don't you think?=C2=A0 Also any suggestions on a= good sample?=C2=A0 I was thinking something not compiled Groovy, because f= or that you'd just run with Java Docker image, no need for Groovy on pa= th.=C2=A0 Maybe a script of some kind.
    • Check if grapes can be = run from containers
      • Grape seemed to work, was there a particula= r problem you were concerned about?
$ docker run -it --rm --name groovy groovy:jre8-latest
Dec 11, 2016 9:37:40= AM java.util.prefs.FileSystemPreferences$1 run
INFO: Created user preferences = directory.
Type ':help' or ':h' for help= .
-------= -----------------------------------------------------------------= -----------------------------------------------------------------= -----------------------------------------------------------------= ----
groo= vy:000> groovy.grape.Grape.grab(group:'org.springframework'= , module:'spring', version:'2.5.6')
=3D=3D=3D> null
<= /div>

$ docker run -it --rm --name groovy groovy:jre8-latest grape install = 'org.springframework' 'spring' '2.5.6'
=
:: loading settings := : url =3D jar:file:/opt/groovy/lib/ivy-2.4.0.jar!/org/apache/ivy/core/= settings/ivysettings.xml
:: resolving dependencies :: caller#all-caller;working= 72
=C2=A0= =C2=A0 =C2=A0 =C2=A0 confs: [default]
=C2=A0 =C2=A0 =C2=A0 =C2=A0 found org.springf= ramework#spring;2.5.6 in jcenter
=C2=A0 =C2=A0 =C2=A0 =C2=A0 found commons-logg= ing#commons-logging;1.1.1 in jcenter
=C2=A0 =C2=A0 =C2=A0 =C2=A0 [SUCCESSFUL ] org.springframewor= k#spring;2.5.6!spring.jar (2741ms)
=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 [= SUCCESSFUL ] commons-logging#commons-logging;1.1.1!commons-logging.jar= (719ms)

On Sun, Dec = 11, 2016 at 3:32 AM, Thibault Kruse <tibokruse@googlemail.com&g= t; wrote:
Some minor comments:
- might be better not to start groovysh, might be mentioned in
Dockerfile comments instead
- Add Dockerfile comments, at least a link to the repo containing the
dockerfiles
- Add a LICENSE file to the github repo
- Add a travis job to the github repo that verifies the Dockerfiles
- check if grapes can be run from containers
- Provide one sample image on top of those images with some hello
world application


On Sun, Dec 11, 2016 at 3:24 PM, Keegan Witt <keeganwitt@gmail.com> wrote:
> Sorry for the long turnaround on this.=C2=A0 I've got some basic D= ockerfiles put
> together: https://github.com/keeganwitt/groovy= -docker.=C2=A0 Please let me know
> what I can improve.=C2=A0 One thing I might do is template out the Doc= kerfiles
> similar to what Ruby did to make it easier to publish images when ther= e's a
> new Groovy version.
>
> I planned on creating both Alpine and non-Alpine images since that see= ms to
> be the current practice.=C2=A0 But we need to get GROOVY-7906 resolved= for the
> Alpine images to work.
>
> I'm concerned about whether it'd be legal for us to distribute= the Oracle
> JDK with Groovy.=C2=A0 I saw this article on the topic:
> http://blog.takipi.com/run= ning-java-on-docker-youre-breaking-the-law/.=C2=A0 I
> don't speak legalize though.=C2=A0 I haven't seen anyone else = (Jruby, etc)
> publishing Oracle JDK, and Oracle has never published Docker images th= at
> were not OpenJDK.=C2=A0 The only images floating out there have been > community-created.=C2=A0 So for the time being, I don't plan to pu= blish Oracle
> based images.
>
> Once we think these look good, I'll move the repo over to groovy o= rg in
> Github and we'll get them published to Docker Hub.=C2=A0 Maybe we = could also ask
> Apache Infra to get them added to https://hub.docker.com/u/apac= he/, I
> haven't decided.=C2=A0 What do you think?
>
> On Fri, Sep 9, 2016 at 11:19 PM, Corum, Michael <mcorum@rgare.com> wrote:
>>
>> Not related to Groovy as much.=C2=A0 We=E2=80=99ve never been able= to get OpenJDK (7 or
>> 8) to work properly with Oracle JDBC drivers on Alpine.=C2=A0 Alwa= ys have to use
>> Oracle JDK and in the research we did, we found others with the sa= me issues.
>>
>> Michael Corum
>>
>> VP, Technical Architecture Solutions
>>
>>
>>
>> RGA Reinsurance Company
>>
>> 16600 Swingley Ridge Road
>>
>> Chesterfield, Missouri 6301701706
>>
>> T 636.736.7066
>>
>> www.rgare.com
>>
>>
>>
>>
>> From: Guillaume Laforge <glaforge@gmail.com>
>> Reply-To: "users@groovy.apache.org" <users@groovy.apache.org>
>> Date: Friday, September 9, 2016 at 10:16 PM
>> To: "users@groovy.apache.org" <users@groovy.apache.org>
>> Subject: Re: Groovy Docker images
>>
>> Out of curiosity, what's the problem with OpenJDK?
>> Is it related to Groovy or not at all?
>>
>> On Sat, Sep 10, 2016 at 5:09 AM, Corum, Michael <mcorum@rgare.com> wrote:
>>>
>>>
>>> Either one
>>> Alpine =E2=80=93 I suspect others will want other options thou= gh
>>> Would most definitely prefer Oracle but I assume other would w= ant OpenJDK
>>> as well.=C2=A0 For my purposes OpenJDK just doesn=E2=80=99t wo= rk at all.
>>>
>>> Michael Corum
>>>
>>> VP, Technical Architecture Solutions
>>>
>>>
>>>
>>> RGA Reinsurance Company
>>>
>>> 16600 Swingley Ridge Road
>>>
>>> Chesterfield, Missouri 6301701706
>>>
>>> T 636.736.7066
>>>
>>> www.rgare.com
>>>
>>>
>>>
>>>
>>> From: Keegan Witt <keeganwitt@gmail.com>
>>> Reply-To: "users@groovy.apache.org" <users@groovy.apache.org>
>>> Date: Friday, September 9, 2016 at 9:48 PM
>>> To: "users@groovy.apache.org" <users@groovy.apache.org>
>>> Subject: Groovy Docker images
>>>
>>> I was thinking of putting together some Docker images for Groo= vy, with
>>> the idea they might be useful to base Grails, Gradle, etc imag= es on and
>>> wondered people's opinions on a few things.
>>>
>>> Should I install Groovy manually in somewhere like /opt?=C2=A0= Or use SDKMAN?
>>> Should I have images based on Alpine and Debian? Alpine only?<= br> >>> I presume OpenJDK images are fine as bases?=C2=A0 Any reason w= e'd need an
>>> Oracle based image too?
>>>
>>> Thoughts?
>>>
>>> -Keegan
>>
>>
>>
>>
>> --
>> Guillaume Laforge
>> Apache Groovy committer & PMC Vice-President
>> Developer Advocate @ Google Cloud Platform
>>
>> Blog: http://glaforge.appspot.com/
>> Social: @glaforge / Google+
>
>


--001a11410f72d3f43d05438a057a--