Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
From: Jim Northrop <james.b.northrop@googlemail.com>
Content-Type: multipart/alternative;
	boundary=Apple-Mail-7197446A-0DEE-4F11-9943-E99FBD1D745D
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (1.0)
Subject: Re: More Antlr4-based Groovy parser status update
Message-Id: <BDDE3AC5-2CAF-4296-9DED-41B134F1F3A1@googlemail.com>
Date: Fri, 11 Mar 2016 18:21:37 +0100
References: <29FC6596-94BC-4BE2-A9A9-2FA48680CC08@selskabet.org>
 <CAJ2HCd8wzWqpgkdn6BZ7zZ93842XghLuzuASdc4tOHjzbzQP9g@mail.gmail.com>
 <BC0E4CC6-3D9D-4D18-9420-ED622D1FA6C1@selskabet.org>
 <D2FC84CD-DD73-4A31-86E9-813643D9F0B0@selskabet.org>
 <CAJ2HCd9_V6kou8ZcG+QvETqY=2K7m06NABBbt1Gw1NFx2_wM+g@mail.gmail.com>
In-Reply-To: 
 <CAJ2HCd9_V6kou8ZcG+QvETqY=2K7m06NABBbt1Gw1NFx2_wM+g@mail.gmail.com>
To: "dev@groovy.apache.org" <dev@groovy.apache.org>


--Apple-Mail-7197446A-0DEE-4F11-9943-E99FBD1D745D
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

+1 =F0=9F=91=8F

Sent from my iPad

> On 11 Mar 2016, at 11:11, Guillaume Laforge <glaforge@gmail.com> wrote:
>=20
> By the way, I had a question (unrelated to the below thread, but related t=
o the grammar) :-)
>=20
> Do you keep the comment information?
> It's something we've always said we should support, and it would tremendou=
sly help making a less hackish groovydoc tool.
> Having AST nodes for JavaDoc comments would really be great.
>=20
> Guillaume
>=20
>> On Sun, Feb 28, 2016 at 12:55 PM, Jesper Steen M=C3=B8ller <jesper@selska=
bet.org> wrote:
>> Hi Groovy-Dev
>>=20
>> Here=E2=80=99s another update on the progress on the Antlr4 parser, as ma=
intained on https://github.com/jespersm/groovy.git (in the antlr4 branch).
>> To play with it, try:
>>=20
>> $ git clone -b antlr4 https://jespersm@github.com/jespersm/groovy.git
>> $ cd groovy
>> $ gradle -PuseAntlr4=3Dtrue console
>>=20
>> I=E2=80=99ve fixed a number of issues:
>> Support method pointer operator
>> Attributes/method/property names as strings/gstrings
>> Real support for unary plus and minus (mimics old parser=E2=80=99s behavi=
our)
>> Compilation units not ending with semicolon or newline
>> Slashy strings could span lines, confusing division statements and commen=
ts
>> I can now explore the new grammar and AST building using the Console, whi=
ch is fun, but it=E2=80=99s very easy to find unsupported constructs. Mappin=
g out the full Groovy grammar from the documentation alone is quite a task. J=
ust today, I discovered lacking support for =E2=80=98assert=E2=80=99 and for=
 =E2=80=99super=E2=80=99-calls. The smaller issues currently are:
>> assert
>> super()
>> Full Unicode letter support  for identifiers
>> Support identifiers as property names and map literal entry names
>>=20
>> The bigger issue is with converting the ASTBuilder to pure Java, a task I=
 havn=E2=80=99t started yet. Actually, this poses a different question for A=
ST generation: Whether to switch from tree-walking the parse tree (so whole t=
ree must be kept in memory), to the listener-based approach, where the AST i=
s built mostly bottom-up, ensuring smaller memory footprint.
>>=20
>> So you can help me with a couple of answers:
>> Memory: Is this an issue I should be focusing on =E2=80=94 and is there a=
 test to baseline against?
>> I=E2=80=99ve discovered a small issue with unary syntax. Currently, neste=
d unary expressions are not supported without parenthesis: Try e.g. - -1 or +=
 -1. Is this intentional, or just an artifact of the precedence-refactored J=
ava grammar?
>>=20
>> -Jesper
>=20
>=20
>=20
> --=20
> Guillaume Laforge
> Apache Groovy committer & PMC Vice-President
> Product Ninja & Advocate at Restlet
>=20
> Blog: http://glaforge.appspot.com/
> Social: @glaforge / Google+

--Apple-Mail-7197446A-0DEE-4F11-9943-E99FBD1D745D
Content-Type: text/html;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D=
utf-8"></head><body dir=3D"auto"><div>+1 =F0=9F=91=8F<br><br>Sent from my iP=
ad</div><div><br>On 11 Mar 2016, at 11:11, Guillaume Laforge &lt;<a href=3D"=
mailto:glaforge@gmail.com">glaforge@gmail.com</a>&gt; wrote:<br><br></div><b=
lockquote type=3D"cite"><div><div dir=3D"ltr">By the way, I had a question (=
unrelated to the below thread, but related to the grammar) :-)<div><br></div=
><div>Do you keep the comment information?</div><div>It's something we've al=
ways said we should support, and it would tremendously help making a less ha=
ckish groovydoc tool.</div><div>Having AST nodes for JavaDoc comments would r=
eally be great.</div><div><br></div><div>Guillaume</div></div><div class=3D"=
gmail_extra"><br><div class=3D"gmail_quote">On Sun, Feb 28, 2016 at 12:55 PM=
, Jesper Steen M=C3=B8ller <span dir=3D"ltr">&lt;<a href=3D"mailto:jesper@se=
lskabet.org" target=3D"_blank">jesper@selskabet.org</a>&gt;</span> wrote:<br=
><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div style=3D"word-wrap:break-word">Hi Groovy=
-Dev<div><br></div><div>Here=E2=80=99s another update on the progress on the=
 Antlr4 parser, as maintained on&nbsp;<b><a href=3D"https://github.com/jespe=
rsm/groovy.git" target=3D"_blank">https://github.com/jespersm/groovy.git</a>=
</b> (in the <b>antlr4</b> branch).</div><div>To play with it, try:</div><di=
v><br></div><blockquote style=3D"margin:0 0 0 40px;border:none;padding:0px">=
<div>$ git clone -b antlr4 <a href=3D"https://jespersm@github.com/jespersm/g=
roovy.git" target=3D"_blank">https://jespersm@github.com/jespersm/groovy.git=
</a></div><div>$ cd groovy</div><div>$ gradle -PuseAntlr4=3Dtrue console</di=
v></blockquote><div><br></div><div>I=E2=80=99ve fixed a number of issues:</d=
iv><div><ul><li>Support method pointer operator</li><li>Attributes/method/pr=
operty names as strings/gstrings</li><li>Real support for unary plus and min=
us (mimics old parser=E2=80=99s behaviour)</li><li>Compilation units not end=
ing with semicolon or newline</li><li>Slashy strings could span lines, confu=
sing division statements and comments</li></ul></div><div>I can now explore t=
he new grammar and AST building using the Console, which is fun, but it=E2=80=
=99s very easy to find unsupported constructs. Mapping out the full Groovy g=
rammar from the documentation alone is quite a task. Just today, I discovere=
d lacking support for =E2=80=98assert=E2=80=99 and for =E2=80=99super=E2=80=99=
-calls. The smaller issues currently are:</div><div><ul><li>assert</li><li>s=
uper()</li><li>Full Unicode letter support &nbsp;for identifiers</li><li>Sup=
port identifiers as property names and map literal entry names</li></ul></di=
v><div><br></div><div>The bigger issue is with converting the ASTBuilder to p=
ure Java, a task I havn=E2=80=99t started yet. Actually, this poses a differ=
ent question for AST generation: Whether to switch from tree-walking the par=
se tree (so whole tree must be kept in memory), to the listener-based approa=
ch, where the AST is built mostly bottom-up, ensuring smaller memory footpri=
nt.</div><div><br></div><div>So you can help me with a couple of answers:</d=
iv><div><ul><li>Memory: Is this an issue I should be focusing on =E2=80=94 a=
nd is there a test to baseline against?</li><li>I=E2=80=99ve discovered a sm=
all issue with unary syntax. Currently, nested unary expressions are not sup=
ported without parenthesis: Try e.g. - -1 or + -1. Is this intentional, or j=
ust an artifact of the precedence-refactored Java grammar?</li></ul></div><s=
pan class=3D"HOEnZb"><font color=3D"#888888"><div><br></div><div>-Jesper</di=
v><div><br></div></font></span></div></blockquote></div><br><br clear=3D"all=
"><div><br></div>-- <br><div class=3D"gmail_signature"><div dir=3D"ltr"><div=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Gu=
illaume Laforge<br>Apache Groovy committer &amp; PMC Vice-President</div><di=
v dir=3D"ltr">Product Ninja &amp; Advocate at <a href=3D"http://restlet.com"=
 target=3D"_blank">Restlet</a><br><div><br></div><div>Blog:&nbsp;<a href=3D"=
http://glaforge.appspot.com/" target=3D"_blank">http://glaforge.appspot.com/=
</a><div><div>Social: <a href=3D"http://twitter.com/glaforge" target=3D"_bla=
nk">@glaforge</a>&nbsp;/ <a href=3D"https://plus.google.com/u/0/114130972232=
398734985/posts" target=3D"_blank">Google+</a></div></div></div></div></div>=
</div></div></div></div></div></div>
</div>
</div></blockquote></body></html>=

--Apple-Mail-7197446A-0DEE-4F11-9943-E99FBD1D745D--