From notifications-return-5802-archive-asf-public=cust-asf.ponee.io@freemarker.apache.org Tue Nov 27 20:40:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 34100180677 for ; Tue, 27 Nov 2018 20:40:04 +0100 (CET) Received: (qmail 62317 invoked by uid 500); 27 Nov 2018 19:40:03 -0000 Mailing-List: contact notifications-help@freemarker.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@freemarker.apache.org Delivered-To: mailing list notifications@freemarker.apache.org Received: (qmail 62308 invoked by uid 99); 27 Nov 2018 19:40:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2018 19:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CC6DDC21DC for ; Tue, 27 Nov 2018 19:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_SHORT=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 1mO72vK6QZAY for ; Tue, 27 Nov 2018 19:40:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BEA475FAE3 for ; Tue, 27 Nov 2018 19:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C03DCE2072 for ; Tue, 27 Nov 2018 19:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 48A0B27766 for ; Tue, 27 Nov 2018 19:40:00 +0000 (UTC) Date: Tue, 27 Nov 2018 19:40:00 +0000 (UTC) From: "Daniel Dekany (JIRA)" To: notifications@freemarker.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (FREEMARKER-109) Invalid function signature - IAE when loading TLD functions with line breaks. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FREEMARKER-109?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dekany resolved FREEMARKER-109. -------------------------------------- Resolution: Fixed Fix Version/s: 2.3.29 Thanks!=C2=A0Fix committed for the next release. > Invalid function signature - IAE when loading TLD functions with line bre= aks. > -------------------------------------------------------------------------= ---- > > Key: FREEMARKER-109 > URL: https://issues.apache.org/jira/browse/FREEMARKER-109 > Project: Apache Freemarker > Issue Type: Bug > Components: jsp > Affects Versions: 2.3.27-incubating, 2.3.28 > Reporter: Magnus Le=C3=9Fmann > Priority: Minor > Fix For: 2.3.29 > > Attachments: FreemarkerIssueDemo.java, demo.ftl, demo.tld > > > When a taglib descriptor file contains a function definition with line br= eaks in the function signature, the TaglibFactory fails to load the taglib = with an ``IllegalArgumentException`` complaining about an invalid function = signature. > The pattern ``FUNCTION_SIGNATURE_PATTERN`` from ``TagLibMethodUtil`` does= not support function signatures containing newline characters. > However, having the ability for newline characters is important to mainta= in readability with the FQNs. > I did not see any reason why line breaks would be forbidden in TLD files = as the taglib can be loaded by our application and=C2=A0[the XML definition= clearly states this as allowed|https://www.w3.org/TR/REC-xml/#sec-line-end= s] > I have attached an example. And I believe fixing this will not be that bi= g of a deal. > Maybe setting the flag ``Pattern.DOTALL`` is enough to resolve this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)