From notifications-return-5024-archive-asf-public=cust-asf.ponee.io@freemarker.incubator.apache.org Mon Feb 12 01:57:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5027A18064E for ; Mon, 12 Feb 2018 01:57:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4060F160C60; Mon, 12 Feb 2018 00:57:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 85FDA160C4E for ; Mon, 12 Feb 2018 01:57:03 +0100 (CET) Received: (qmail 31716 invoked by uid 500); 12 Feb 2018 00:57:02 -0000 Mailing-List: contact notifications-help@freemarker.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@freemarker.incubator.apache.org Delivered-To: mailing list notifications@freemarker.incubator.apache.org Received: (qmail 31704 invoked by uid 99); 12 Feb 2018 00:57:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Feb 2018 00:57:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 32B3518032A for ; Mon, 12 Feb 2018 00:57:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id vQl94gocrOvW for ; Mon, 12 Feb 2018 00:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 243765F6BE for ; Mon, 12 Feb 2018 00:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 97B83E00B5 for ; Mon, 12 Feb 2018 00:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 283DE21E83 for ; Mon, 12 Feb 2018 00:57:00 +0000 (UTC) Date: Mon, 12 Feb 2018 00:57:00 +0000 (UTC) From: "Yanming Zhou (JIRA)" To: notifications@freemarker.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FREEMARKER-84) Improve include directive to detect whether template exists MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FREEMARKER-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360197#comment-16360197 ] Yanming Zhou commented on FREEMARKER-84: ---------------------------------------- "get_optional_template" is a good design, I like it. > Improve include directive to detect whether template exists > ----------------------------------------------------------- > > Key: FREEMARKER-84 > URL: https://issues.apache.org/jira/browse/FREEMARKER-84 > Project: Apache Freemarker > Issue Type: Improvement > Components: engine > Affects Versions: 2.3.27-incubating > Reporter: Yanming Zhou > Priority: Major > > I requested feature `ignore_missing=true` of <#include> and freemarker have implemented it, but it cannot handle fallback like > {code} > <#assign path="relative.ftl"> > <#if isTemplatePresent(path)> > <#include path> > <#else> > template "${path}" is not exists > > {code} > Proposal 1: > Introduce a new special variable like "template_included" similar to "$?" of shell exit code > {code} > <#include path ignore_missing=true> > <#if !.template_included> > template "${path}" is not exists > > {code} > Proposal 2: > Add an argument like "template_included" for include directive > {code} > <#include path ignore_missing=true template_included="pathExists"> > <#if !pathExists> > template "${path}" is not exists > > {code} > Proposal 3: > Introduce a new special directive such as <#missing> similar to html