Mailing-List: contact notifications-help@fluo.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@fluo.incubator.apache.org
From: keith-turner <git@git.apache.org>
To: notifications@fluo.incubator.apache.org
Reply-To: notifications@fluo.incubator.apache.org
References: <git-pr-817-incubator-fluo@git.apache.org>
In-Reply-To: <git-pr-817-incubator-fluo@git.apache.org>
Subject: [GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...
Content-Type: text/plain
Message-Id: <20170320210709.C7EA9DFE1D@git1-us-west.apache.org>
Date: Mon, 20 Mar 2017 21:07:09 +0000 (UTC)
archived-at: Mon, 20 Mar 2017 21:07:14 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/817#discussion_r107016744
  
    --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/StringObserver.java ---
    @@ -0,0 +1,34 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
    + * agreements. See the NOTICE file distributed with this work for additional information regarding
    + * copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance with the License. You may obtain a
    + * copy of the License at
    + * 
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * 
    + * Unless required by applicable law or agreed to in writing, software distributed under the License
    + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
    + * or implied. See the License for the specific language governing permissions and limitations under
    + * the License.
    + */
    +
    +package org.apache.fluo.api.observer;
    +
    +import org.apache.fluo.api.client.TransactionBase;
    +import org.apache.fluo.api.data.Bytes;
    +import org.apache.fluo.api.data.Column;
    +
    +/**
    + * @since 1.1.0
    + */
    +@FunctionalInterface
    +public interface StringObserver extends Observer {
    +
    +  @Override
    +  default void process(TransactionBase tx, Bytes row, Column col) throws Exception {
    +    process(tx, row.toString(), col);
    --- End diff --
    
    The reason I don't think the NPE check is needed, is because I think row.toString() is the only thing on that line that can cause an NPE.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---