From api-return-1083-archive-asf-public=cust-asf.ponee.io@directory.apache.org Mon Mar 22 16:05:43 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 66A6B180621 for ; Mon, 22 Mar 2021 17:05:43 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 98A7242844 for ; Mon, 22 Mar 2021 16:05:42 +0000 (UTC) Received: (qmail 56132 invoked by uid 500); 22 Mar 2021 16:05:42 -0000 Mailing-List: contact api-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list api@directory.apache.org Received: (qmail 56120 invoked by uid 99); 22 Mar 2021 16:05:42 -0000 Received: from spamproc1-he-de.apache.org (HELO spamproc1-he-de.apache.org) (116.203.196.100) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Mar 2021 16:05:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-de.apache.org (ASF Mail Server at spamproc1-he-de.apache.org) with ESMTP id 4F8981FF47B for ; Mon, 22 Mar 2021 16:05:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-de.apache.org X-Spam-Flag: NO X-Spam-Score: 2.788 X-Spam-Level: ** X-Spam-Status: No, score=2.788 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENA_SUBJ_ODD_CASE=3.2, NICE_REPLY_A=-0.211, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamproc1-he-de.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-de.apache.org [116.203.196.100]) (amavisd-new, port 10024) with ESMTP id hzIinzs-ajHe for ; Mon, 22 Mar 2021 16:05:41 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::334; helo=mail-wm1-x334.google.com; envelope-from=elecharny@gmail.com; receiver= Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id E131E7FC98 for ; Mon, 22 Mar 2021 16:05:40 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id y124-20020a1c32820000b029010c93864955so11455373wmy.5 for ; Mon, 22 Mar 2021 09:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=+LyiGI+am/00p2ca9OFr0cK9dIBdlGPjj/oBfyPSa/E=; b=YCJp6OefL7B95uQ3k6xsLm0+CG2SA+Kb6CG3iNCTIk/Ewl+4gk4Mctr1MD1u8oiOFE 3Lsct4qG2ZYXEXBC3OperUR7c2gdF+sLnoAwiXkJB38TLNWo1vLXfYhhPYrXnau1W34N H9XzNoqp4HlEI+U99IVPvHrxwzrsVGdmdjS4BgdaB/EiZWudsgmoOZLGs+ohjJXmg5kH QJlJoRIdaXbOgqU0zdMZrWqwsDWj4ZpjlPjMBiK+4XX/oLZAFYPgo1fu1jK2o7NHCExY wA9OhTS+8TWZsdZrnqK/S5tsr89BdQwAC4gnCvyX6Hb/o6/DhC5hVJ2Wee8DkZCiC1Z8 ufKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+LyiGI+am/00p2ca9OFr0cK9dIBdlGPjj/oBfyPSa/E=; b=hPsx3Kz7uqblLha55k/GQZfHJuMt3lGFtyBhpwEIsyIr3c6w4uJgmti6S37V48RYWd d3Q9zth/KotaCoRuXVN9iTMASxzhevBzl+bKkfx2LaIQS+93qt22cZR8bf2qWu+bIrrm ddfYJDQJM0d8ArRfro5drjWYLhDysPbUXp1boeSN/g3Obt6zUO3jL3D+5zH1FZtlG4EG oTJ0ffYyvibhlwRmhH0epXoaYUhqFG81QnpwF7CUBAUlhXxqUu6OHbyfbqPYTrBcnsE0 p37VaqQGLTNwvms2SSJauMSk1Eh4zAoQaRzarQLH6OICUCPUSZv/og6E+ZLlSn3m5cBk VUOw== X-Gm-Message-State: AOAM533888IduiZgOK3u4xvaTnQHtKUL9rh/29rIxtaX3jPx3mOgA+a6 d2/byhfzMuD8vhubqaKYRWW9beNAb+M= X-Google-Smtp-Source: ABdhPJzlnxt3vCWJ8HPEQKKHK3R1kmqCcYcbfeZwNNB9Q35YHZ0YQWrFS7ve1TqMpPdYoJybu/ahmQ== X-Received: by 2002:a05:600c:4282:: with SMTP id v2mr505138wmc.80.1616429140118; Mon, 22 Mar 2021 09:05:40 -0700 (PDT) Received: from [192.168.8.4] ([109.94.60.193]) by smtp.gmail.com with ESMTPSA id c16sm24482825wrs.81.2021.03.22.09.05.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 09:05:39 -0700 (PDT) Subject: Re: LdapConnectionPool.getConnection doing extraneous search? To: api@directory.apache.org References: <1CDE07B8-5AAA-48DA-B364-D87F9678179C@apache.org> <6c683582-3f9d-2bb8-21ae-2723f08a3de4@gmail.com> <811583D9-F9A8-4F28-90DF-CCBBDC380861@apache.org> <41EE2818-F802-415D-B740-0D8EE699959C@apache.org> From: =?UTF-8?Q?Emmanuel_L=c3=a9charny?= Message-ID: <67ade323-6b58-ac82-d6dc-fd6e37fa8de0@gmail.com> Date: Mon, 22 Mar 2021 17:05:38 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <41EE2818-F802-415D-B740-0D8EE699959C@apache.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 22/03/2021 16:45, Shawn McKinney wrote: > >> On Mar 22, 2021, at 10:43 AM, Shawn McKinney wrote: >> >>> >>> The risk not doing such a check is very very tenuous. >> > > Sorry, but asking for a clarification here. Do you mean, not doing the check is risky? Or, is OK. LDAP connections are quite stable. Again, this check is there to respect the commons-pool API contract. If the connection is dead, then doing this check will let the pool fetching another connection, which is good. OTOH, if you don't want to check connections while fetching one, then you are on your own (ie, deal with the consequences of a bad connection). Usually, under heavy charged systems, it's better not to check connections, except on exceptional conditions: * if the connection works, well, you are good to go * if it fails, it's time to activate contingency plans (here, try to borrow another connection from the pool) You are very much likely to fell in the first situation. --------------------------------------------------------------------- To unsubscribe, e-mail: api-unsubscribe@directory.apache.org For additional commands, e-mail: api-help@directory.apache.org