From api-return-995-archive-asf-public=cust-asf.ponee.io@directory.apache.org Wed May 16 15:30:40 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 88561180669 for ; Wed, 16 May 2018 15:30:40 +0200 (CEST) Received: (qmail 87316 invoked by uid 500); 16 May 2018 13:30:39 -0000 Mailing-List: contact api-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: api@directory.apache.org Delivered-To: mailing list api@directory.apache.org Received: (qmail 87305 invoked by uid 99); 16 May 2018 13:30:39 -0000 Received: from ui-eu-01.ponee.io (HELO localhost) (176.9.59.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 May 2018 13:30:39 +0000 MIME-Version: 1.0 From: Emmanuel Lecharny X-Mailer: LuaSocket 3.0-rc1 Content-Type: text/plain; charset=utf-8 Subject: Re: Fast openldap schema parser : completed References: <131d58ea-6f89-cd5c-082b-945593844199@gmail.com> To: x-ponymail-sender: 9d55c29c020f0607a252243a305e8fed47d50b37 Date: Wed, 16 May 2018 13:30:37 -0000 In-Reply-To: <131d58ea-6f89-cd5c-082b-945593844199@gmail.com> x-ponymail-agent: PonyMail Composer/0.3 Message-ID: Ok, I have fixed Studio to have it working fine with the modified API. It seems to be faster to open now (15s when launched from Eclipse, against 21" for a previous version). Stefan, can you confirm that it's the case ? Thanks ! On 2018/05/16 08:25:42, Emmanuel Lécharny wrote: > Hi ! > > I finally committed the new parser. I did my best to have the same API, > so ou can use it as if it were the previous version, except that it does > not use AntLR anymore. > > The final performance results : > > new parser, core schema parsed 100 000 times : 31s > old parser, core schema parsed 10 000 times : 100s > > ratio : 32 times faster (it's a bit slower than what I said in my > previous mails, but I have added various checks that slow down the > parser - mainly checks on OID validity -. > > > Radovan, you are free to check with your various LDAP server if the code > is ok for you, and if not, I'm ready to fix it. > > Side notes : > - I'm now using static methods for the various schema parsers, so there > is no synchronization anymore > - I found *many* errors in the previous implementation... > - the Strict mode is not as strict as it could be : we typically accept > OID macros (that allows us to have things like "attributeType ( > MyRootOid:2.3.4 ...)" to be used, where 'MyRootOid' is defined using a > ObjectIdentifier element. This is ultra convenientt, and does not put us > at risk. > - The code has been pushed in the API 2.0 branch. > > I haven't yet tested Studio with this new code, this is soemthing I'll > do soon. > > Hope you'll find that convenient ! > -- > Emmanuel Lecharny > > Symas.com > directory.apache.org > >