Mailing-List: contact api-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: api@directory.apache.org
Received-SPF: pass (athena.apache.org: domain of damien.dube@gmail.com
 designates 209.85.210.178 as permitted sender)
MIME-Version: 1.0
From: =?UTF-8?B?RGFtaWVuIER1YsOp?= <damien.dube@gmail.com>
Date: Thu, 15 Nov 2012 15:57:04 -0500
Message-ID: 
 <CAO4JwDkgmb10--HmHiq_euHEqTeizwA9B7dz9j7cZxazJgV7xA@mail.gmail.com>
Subject: bug in LdapConnectionPool.
To: api <api@directory.apache.org>
Content-Type: multipart/alternative; boundary=90e6ba6e8f38e047f304ce8ee579

--90e6ba6e8f38e047f304ce8ee579
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I found a bug in LdapConnectionPool.

If a Connection fails on credentials, the LdapConnection is not closed and
is not in the pool.

I modified the makeObject() function
in PoolableLdapConnectionFactory.java to this

    public Object makeObject() throws Exception
    {
        LOG.debug("creating a LDAP connection");

        LdapNetworkConnection connection =3D new
LdapNetworkConnection(config);
        try {
            connection.bind(config.getName(), config.getCredentials());
        } catch (Exception e1) {
            try {
                connection.close();
            } catch (Exception e2) {

            }
            throw e1;
        }
        return connection;
    }

It seems to be doing the trick!


Damien Dub=C3=A9
damien.dube@gmail.com

--90e6ba6e8f38e047f304ce8ee579--