Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@deltacloud.apache.org
Received-SPF: pass (nike.apache.org: domain of mfojtik@redhat.com designates
 209.132.183.28 as permitted sender)
Subject: Re: [PATCH 5/5] Adds create operation to CIMI::Volume model
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=us-ascii
From: Michal Fojtik <mfojtik@redhat.com>
In-Reply-To: <1322242039-30326-6-git-send-email-marios@redhat.com>
Date: Mon, 28 Nov 2011 11:11:51 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <F0011B5A-EEFC-4552-AF68-B7D603EA6505@redhat.com>
References: <1322242039-30326-1-git-send-email-marios@redhat.com>
 <1322242039-30326-6-git-send-email-marios@redhat.com>
To: dev@deltacloud.apache.org


On Nov 25, 2011, at 6:27 PM, marios@redhat.com wrote:

> From: marios <marios@redhat.com>
>=20
>=20
> Signed-off-by: marios <marios@redhat.com>
> ---
> server/lib/cimi/model/volume.rb |   17 +++++++++++++++++
> 1 files changed, 17 insertions(+), 0 deletions(-)
>=20
> diff --git a/server/lib/cimi/model/volume.rb =
b/server/lib/cimi/model/volume.rb
> index 4bdd6ca..695546d 100644
> --- a/server/lib/cimi/model/volume.rb
> +++ b/server/lib/cimi/model/volume.rb
> @@ -43,6 +43,23 @@ class CIMI::Model::Volume < CIMI::Model::Base
>=20
>   def self.all(_self); find(:all, _self); end
>=20
> +  def self.create(params, _self)
> +    case params[:content_type]
> +      when :json
> +        json =3D JSON.parse(_self.request.body.read)
> +        volume_config_id =3D =
json["volumeTemplate"]["volumeConfig"]["href"].split("/").last
> +        volume_image_id =3D =
(json["volumeTemplate"].has_key?("volumeImage") ? =
json["volumeTemplate"]["volumeImage"]["href"].split("/").last  : nil)
> +      when :xml
> +        xml =3D XmlSimple.xml_in(_self.request.body.read)
> +        volume_config_id =3D =
xml["volumeTemplate"][0]["volumeConfig"][0]["href"].split("/").last
> +        volume_image_id =3D =
(xml["volumeTemplate"][0].has_key?("volumeImage") ? =
xml["volumeTemplate"][0]["volumeImage"][0]["href"].split("/").last  : =
nil)
> +    end
> +    volume_config =3D VolumeConfiguration.find(volume_config_id, =
_self)
> +    opts =3D {:capacity=3D>volume_config.capacity[:quantity], =
:snapshot_id=3D>volume_image_id }
> +    storage_volume =3D =
self.driver.create_storage_volume(_self.credentials, opts)
> +    from_storage_volume(storage_volume, _self)

I think it would be better to split this method to:

def self.create_from_json(params, _self)
def self.create_from_xml(params, _self)

This two could return an array so:

data, volume_config_id, volume_image_id =3D create_from_json

def self.create(params, _self)

What do you think?


------------------------------------------------------
Michal Fojtik, mfojtik@redhat.com
Deltacloud API: http://deltacloud.org