Mailing-List: contact dev-help@deltacloud.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@deltacloud.apache.org
Received-SPF: pass (nike.apache.org: domain of mfojtik@redhat.com designates
 209.132.183.28 as permitted sender)
Subject: Re: [jira] [Created] (DTACLOUD-110) Deleting VMs does not work with
 rhevm backend
Mime-Version: 1.0 (Apple Message framework v1251.1)
Content-Type: text/plain; charset=us-ascii
From: Michal Fojtik <mfojtik@redhat.com>
In-Reply-To: 
 <497583058.14889.1322411080091.JavaMail.tomcat@hel.zones.apache.org>
Date: Mon, 28 Nov 2011 10:43:05 +0100
Cc: deltacloud-dev@incubator.apache.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <35A580AC-AB3D-4D44-89EC-D4B2713B8385@redhat.com>
References: 
 <497583058.14889.1322411080091.JavaMail.tomcat@hel.zones.apache.org>
To: dev@deltacloud.apache.org

On Nov 27, 2011, at 5:24 PM, Alfredo Moralejo (Created) (JIRA) wrote:

Thanks Alfredo! Patch was pushed to SVN.

 -- Michal

> Deleting VMs does not work with rhevm backend
> ---------------------------------------------
>=20
>                 Key: DTACLOUD-110
>                 URL: =
https://issues.apache.org/jira/browse/DTACLOUD-110
>             Project: DeltaCloud
>          Issue Type: Bug
>          Components: Server
>         Environment: deltacloud 0.4.1 (latest version)
>            Reporter: Alfredo Moralejo
>            Assignee: David Lutterkort
>=20
>=20
> When trying to delete a VM in a RHEVM backend I get an error:
>=20
> curl -u admin@internal:XXXX -X DELETE =
http://cf1:3003/api/instances/3930521c-9e71-407b-878d-6ac47fdea78d
>=20
> I get following error from backend:
>=20
> [root@cf1 core]# /usr/bin/deltacloudd[8324]: =
RestClient::BadRequest:400 Bad Request
>=20
> According with doc of RHEV-M API in =
http://docs.redhat.com/docs/en-US/Red_Hat_Enterprise_Virtualization/3.0/ht=
ml-single/REST_API_Guide/index.html#sect-REST_API_Guide-Common_Features-Re=
sources-Deleting_Resources the header must only contain "Accept" and =
it's adding Content-Type too.
>=20
> I've applied following patch and it's seems to be working fine now:
>=20
> diff --git a/server/lib/deltacloud/drivers/rhevm/rhevm_client.rb =
b/server/lib/deltacloud/drivers/rhevm/rhevm_client.rb
> index 49f6509..908eae3 100644
> --- a/server/lib/deltacloud/drivers/rhevm/rhevm_client.rb
> +++ b/server/lib/deltacloud/drivers/rhevm/rhevm_client.rb
> @@ -67,14 +67,19 @@ module RHEVM
>     end
>=20
>     def vm_action(id, action, headers=3D{})
> -      headers.merge!(auth_header)
> -      headers.merge!({
> -        :content_type =3D> 'application/xml',
> -        :accept =3D> 'application/xml',
> -      })
>       if action=3D=3D:delete
> +        headers =3D {}
> +        headers.merge!(auth_header)
> +        headers.merge!({
> +          :accept =3D> 'application/xml',
> +        })
>         RHEVM::client(@api_entrypoint)["/vms/%s" % id].delete(headers)
>       else
> +        headers.merge!(auth_header)
> +        headers.merge!({
> +          :content_type =3D> 'application/xml',
> +          :accept =3D> 'application/xml',
> +        })
>         begin
>           client_response =3D =
RHEVM::client(@api_entrypoint)["/vms/%s/%s" % [id, =
action]].post('<action/>', headers)
>         rescue
>=20
>=20
>=20
>=20
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA =
administrators: =
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: =
http://www.atlassian.com/software/jira
>=20
>=20

------------------------------------------------------
Michal Fojtik, mfojtik@redhat.com
Deltacloud API: http://deltacloud.org