From dev-return-2365-archive-asf-public=cust-asf.ponee.io@datafu.apache.org Tue Jul 16 13:33:29 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CDADE18064E for ; Tue, 16 Jul 2019 15:33:28 +0200 (CEST) Received: (qmail 84672 invoked by uid 500); 16 Jul 2019 13:33:28 -0000 Mailing-List: contact dev-help@datafu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.apache.org Delivered-To: mailing list dev@datafu.apache.org Received: (qmail 84661 invoked by uid 99); 16 Jul 2019 13:33:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jul 2019 13:33:28 +0000 From: GitBox To: dev@datafu.apache.org Subject: [GitHub] [datafu] uzadude commented on a change in pull request #15: Add Spark functionality to DataFu, datafu-spark Message-ID: <156328400775.18783.17423833842254995116.gitbox@gitbox.apache.org> Date: Tue, 16 Jul 2019 13:33:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit uzadude commented on a change in pull request #15: Add Spark functionality to DataFu, datafu-spark URL: https://github.com/apache/datafu/pull/15#discussion_r303911042 ########## File path: datafu-spark/src/main/resources/pyspark_utils/df_utils.py ########## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import pyspark +from pyspark.sql import DataFrame +from pyspark_utils.bridge_utils import _getjvm_class + + +def _get_utils(df): + _gateway = df._sc._gateway + return _getjvm_class(_gateway, "datafu.spark.SparkDFUtilsBridge") + + +# public: + + +def dedup(df, group_col, order_cols = []): Review comment: changed names of `dedup` and `dedup2` to `dedup_with_order` and `dedup_with_combiner` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services