datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eyal Allweil (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DATAFU-83) InUDF does not validate that types are compatible
Date Mon, 11 Sep 2017 13:13:00 GMT

    [ https://issues.apache.org/jira/browse/DATAFU-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161211#comment-16161211
] 

Eyal Allweil commented on DATAFU-83:
------------------------------------

By the way, [~ItsAUsernameRight?], if you're already looking at InUDF, and you'd like another
contribution afterwards, you can also look at [DATAFU-80|https://issues.apache.org/jira/browse/DATAFU-80]
- it's another small change to improve InUDF's behavior. (you can ignore the second part of
that issue, which deals with Java versions).


> InUDF does not validate that types are compatible
> -------------------------------------------------
>
>                 Key: DATAFU-83
>                 URL: https://issues.apache.org/jira/browse/DATAFU-83
>             Project: DataFu
>          Issue Type: Improvement
>            Reporter: Matthew Hayes
>            Priority: Minor
>         Attachments: DATAFU-83.patch, rb36702.patch
>
>
> See the example below.  The input data is a long, but ints are provided to match against.
 Because it uses the Java equals to compare and these are different types, this will never
match, which can lead to confusing results.  I believe it should at least throw an error.
> {code}
>   define I datafu.pig.util.InUDF();
>   
>   data = LOAD 'input' AS (B: bag {T: tuple(v:LONG)});
>   
>   data2 = FOREACH data {
>     C = FILTER B By I(v, 1,2,3);
>     GENERATE C;
>   }
>   
>   describe data2;
>   
>   STORE data2 INTO 'output';
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message