Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@datafu.incubator.apache.org
Date: Tue, 1 Aug 2017 03:29:02 +0000 (UTC)
From: "Matthew Hayes (JIRA)" <jira@apache.org>
To: dev@datafu.incubator.apache.org
Message-ID: <JIRA.12757918.1416987615000.58213.1501558142058@Atlassian.JIRA>
In-Reply-To: <JIRA.12757918.1416987615000@Atlassian.JIRA>
References: <JIRA.12757918.1416987615000@Atlassian.JIRA> <JIRA.12757918.1416987615747@jira-lw-us.apache.org>
Subject: [jira] [Commented] (DATAFU-83) InUDF does not validate that types
 are compatible
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 01 Aug 2017 03:29:26 -0000


    [ https://issues.apache.org/jira/browse/DATAFU-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108326#comment-16108326 ] 

Matthew Hayes commented on DATAFU-83:
-------------------------------------

Thanks for offering to help Kyle.  Also I suggest opening a new RB and adding the DataFu group as a reviewer so everyone sees the RB.  I think only Sonali can updated the existing RB.

> InUDF does not validate that types are compatible
> -------------------------------------------------
>
>                 Key: DATAFU-83
>                 URL: https://issues.apache.org/jira/browse/DATAFU-83
>             Project: DataFu
>          Issue Type: Improvement
>            Reporter: Matthew Hayes
>            Priority: Minor
>         Attachments: DATAFU-83.patch, rb36702.patch
>
>
> See the example below.  The input data is a long, but ints are provided to match against.  Because it uses the Java equals to compare and these are different types, this will never match, which can lead to confusing results.  I believe it should at least throw an error.
> {code}
>   define I datafu.pig.util.InUDF();
>   
>   data = LOAD 'input' AS (B: bag {T: tuple(v:LONG)});
>   
>   data2 = FOREACH data {
>     C = FILTER B By I(v, 1,2,3);
>     GENERATE C;
>   }
>   
>   describe data2;
>   
>   STORE data2 INTO 'output';
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)