datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthew Hayes <matthew.terence.ha...@gmail.com>
Subject Re: Review Request 61378: DATAFU-123 Allow DataFu to include macros
Date Thu, 03 Aug 2017 16:36:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61378/#review182123
-----------------------------------------------------------



Hmm I'm not able to apply the patch.  What command did you use to create it?

```
git am DATAFU-123-2.patch 
Patch format detection failed.
```

- Matthew Hayes


On Aug. 3, 2017, 12:43 p.m., Eyal Allweil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61378/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2017, 12:43 p.m.)
> 
> 
> Review request for DataFu and Matthew Hayes.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-123 Allow DataFu to include macros
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/resources/datafu/count_macros.pig PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/PigTests.java 6fa500d 
>   datafu-pig/src/test/java/datafu/test/pig/macros/MacroTests.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61378/diff/2/
> 
> 
> Testing
> -------
> 
> Gradle pig-tests run successfully
> 
> 
> Thanks,
> 
> Eyal Allweil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message