datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthew Hayes <matthew.terence.ha...@gmail.com>
Subject Re: Review Request 61378: DATAFU-123 Allow DataFu to include macros
Date Wed, 02 Aug 2017 20:31:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61378/#review182034
-----------------------------------------------------------




datafu-pig/src/test/java/datafu/test/pig/macros/MacroTests.java
Lines 32 (patched)
<https://reviews.apache.org/r/61378/#comment257847>

    Should we namespace these scripts? e.g.,
    
    ```
    imports 'datafu/count_macros.pig';
    ```
    
    I'm afraid of there be collisions.


- Matthew Hayes


On Aug. 2, 2017, 1:02 p.m., Eyal Allweil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61378/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2017, 1:02 p.m.)
> 
> 
> Review request for DataFu and Matthew Hayes.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-123 Allow DataFu to include macros
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/resources/count_macros.pig PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/PigTests.java 6fa500d 
>   datafu-pig/src/test/java/datafu/test/pig/macros/MacroTests.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61378/diff/1/
> 
> 
> Testing
> -------
> 
> Gradle pig-tests run successfully
> 
> 
> Thanks,
> 
> Eyal Allweil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message