datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eyal Allweil <eyal_allw...@yahoo.com>
Subject Re: Review Request 46701: DATAFU-117 - New UDF - CountDistinctUpTo
Date Sat, 21 May 2016 18:15:57 GMT


> On May 20, 2016, 5:35 p.m., Matthew Hayes wrote:
> > I reviewed the updated patch on JIRA (RB was not updated).  The changes look good
to me aside from the clear vs gc issue.  If you're good with going with clear over new then
I can go ahead and make the change and commit (without you having to upload a new patch).

Sure, I'm fine with you making the change to clear.


- Eyal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46701/#review134168
-----------------------------------------------------------


On April 27, 2016, 7:44 a.m., Eyal Allweil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46701/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 7:44 a.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-117 - New UDF - CountDistinctUpTo
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/bags/CountDistinctUpTo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java 28292db0c01a1967ea53d9cc3d316e9906d942a8

> 
> Diff: https://reviews.apache.org/r/46701/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eyal Allweil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message