datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eyal Allweil <eyal_allw...@yahoo.com>
Subject Re: Review Request 46701: DATAFU-117 - New UDF - CountDistinctUpTo
Date Thu, 19 May 2016 14:50:29 GMT


> On May 18, 2016, 10:19 p.m., Matthew Hayes wrote:
> > datafu-pig/src/main/java/datafu/pig/bags/CountDistinctUpTo.java, line 147
> > <https://reviews.apache.org/r/46701/diff/1/?file=1361707#file1361707line147>
> >
> >     What about clearing the set so we don't have to garbage collect?

I just reassigned it because the clear() method in HashSet uses Array.fill and I thought it
would be more expensive than just letting it be garbage collected and making a new one.


> On May 18, 2016, 10:19 p.m., Matthew Hayes wrote:
> > datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java, line 22
> > <https://reviews.apache.org/r/46701/diff/1/?file=1361708#file1361708line22>
> >
> >     We already have the testng assertEquals and this gives me a build error.  Can
you confirm this command passes?
> >     
> >     ./gradlew :datafu-pig:test -Dtest.single=BagTests
> >     
> >     I'm getting an error with this.

I removed this line ... don't know why it worked for me (although I think it did)


- Eyal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46701/#review133803
-----------------------------------------------------------


On April 27, 2016, 7:44 a.m., Eyal Allweil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46701/
> -----------------------------------------------------------
> 
> (Updated April 27, 2016, 7:44 a.m.)
> 
> 
> Review request for DataFu.
> 
> 
> Repository: datafu
> 
> 
> Description
> -------
> 
> DATAFU-117 - New UDF - CountDistinctUpTo
> 
> 
> Diffs
> -----
> 
>   datafu-pig/src/main/java/datafu/pig/bags/CountDistinctUpTo.java PRE-CREATION 
>   datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java 28292db0c01a1967ea53d9cc3d316e9906d942a8

> 
> Diff: https://reviews.apache.org/r/46701/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eyal Allweil
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message