Return-Path: X-Original-To: apmail-datafu-dev-archive@minotaur.apache.org Delivered-To: apmail-datafu-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1D0971823C for ; Wed, 9 Mar 2016 17:47:43 +0000 (UTC) Received: (qmail 74289 invoked by uid 500); 9 Mar 2016 17:47:43 -0000 Delivered-To: apmail-datafu-dev-archive@datafu.apache.org Received: (qmail 74251 invoked by uid 500); 9 Mar 2016 17:47:43 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 74240 invoked by uid 99); 9 Mar 2016 17:47:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2016 17:47:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 987A51A0C6F for ; Wed, 9 Mar 2016 17:47:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.349 X-Spam-Level: X-Spam-Status: No, score=-4.349 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id rUn5s3ymTpGe for ; Wed, 9 Mar 2016 17:47:42 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 7A4015FAD3 for ; Wed, 9 Mar 2016 17:47:41 +0000 (UTC) Received: (qmail 73989 invoked by uid 99); 9 Mar 2016 17:47:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Mar 2016 17:47:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C0C3F2C1F5D for ; Wed, 9 Mar 2016 17:47:40 +0000 (UTC) Date: Wed, 9 Mar 2016 17:47:40 +0000 (UTC) From: "Matthew Hayes (JIRA)" To: dev@datafu.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DATAFU-115) Make TupleFromBag implement Accumulator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/DATAFU-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187498#comment-15187498 ] Matthew Hayes commented on DATAFU-115: -------------------------------------- The link to the review isn't viewable to me, probably because the DataFu group needs to be added. However I looked at the patch and it seems fine to me. Tests pass as well. +1 > Make TupleFromBag implement Accumulator > --------------------------------------- > > Key: DATAFU-115 > URL: https://issues.apache.org/jira/browse/DATAFU-115 > Project: DataFu > Issue Type: Improvement > Affects Versions: 1.3.0 > Reporter: Eyal Allweil > Priority: Minor > Labels: performance > Fix For: 1.3.1 > > Attachments: DATAFU-115.patch > > > Similar to [DATAFU-114|https://issues.apache.org/jira/browse/DATAFU-114]. > TupleFromBag doesn't need to hold the bag in memory, and can iterate through it until it reaches the desired tuple. By implementing Accumulator, larger bags can be used and with a smaller memory footprint. -- This message was sent by Atlassian JIRA (v6.3.4#6332)