datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Reid" <ja...@stingrayvbc.com>
Subject Re: Review Request 26694: DATAFU-70: Add BagFullOuterJoin
Date Mon, 20 Oct 2014 19:00:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26694/
-----------------------------------------------------------

(Updated Oct. 20, 2014, 7 p.m.)


Review request for DataFu.


Changes
-------

Updated to address comments from v1.


Repository: datafu


Description
-------

DATAFU-70: Add BagFullOuterJoin


Diffs (updated)
-----

  datafu-pig/src/main/java/datafu/pig/bags/BagJoin.java PRE-CREATION 
  datafu-pig/src/main/java/datafu/pig/bags/BagLeftOuterJoin.java ba6bc11 
  datafu-pig/src/test/java/datafu/test/pig/bags/BagTests.java 6d21dbe 

Diff: https://reviews.apache.org/r/26694/diff/


Testing
-------

Added bagJoinFullOuterTest to BagTests which uses the same input as the bagLeftOuterJoinTest
but asserts the full outer join logic in the output.  I have also refactored the existing
BagLeftOuterJoin class to use the generic BagJoin class and the existing test continues to
pass without modification.


Thanks,

Jason Reid


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message