Return-Path: X-Original-To: apmail-datafu-dev-archive@minotaur.apache.org Delivered-To: apmail-datafu-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E178411253 for ; Mon, 8 Sep 2014 08:58:18 +0000 (UTC) Received: (qmail 14782 invoked by uid 500); 8 Sep 2014 08:58:18 -0000 Delivered-To: apmail-datafu-dev-archive@datafu.apache.org Received: (qmail 14742 invoked by uid 500); 8 Sep 2014 08:58:18 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 14730 invoked by uid 99); 8 Sep 2014 08:58:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2014 08:58:18 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 08 Sep 2014 08:58:17 +0000 Received: (qmail 14586 invoked by uid 99); 8 Sep 2014 08:57:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2014 08:57:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BFAD11C233F; Mon, 8 Sep 2014 08:57:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8385143125183962586==" MIME-Version: 1.0 Subject: Review Request 25428: DATAFU-68 SampleByKey can throw NullPointerException From: "Jarek Cecho" To: "DataFu" , "Jarek Cecho" Date: Mon, 08 Sep 2014 08:57:55 -0000 Message-ID: <20140908085755.23924.46980@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jarek Cecho" X-ReviewGroup: DataFu X-ReviewRequest-URL: https://reviews.apache.org/r/25428/ X-Sender: "Jarek Cecho" Reply-To: "Jarek Cecho" X-ReviewRequest-Repository: datafu X-Virus-Checked: Checked by ClamAV on apache.org --===============8385143125183962586== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25428/ ----------------------------------------------------------- Review request for DataFu. Bugs: DATAFU-68 https://issues.apache.org/jira/browse/DATAFU-68 Repository: datafu Description ------- Attaching patch that: * Fixes trailing whitespaces in the file * Adds validation that signature is not null before calling hashCode * Added check to intToRandomDouble to ensure that we won't use the null Diffs ----- datafu-pig/src/main/java/datafu/pig/sampling/SampleByKey.java d94a038 Diff: https://reviews.apache.org/r/25428/diff/ Testing ------- I didn't add new test case as I wasn't able to easily force Pig to call the method setUDFContextSignature with null parameter on the unit test level. Existing unit tests are passing. Thanks, Jarek Cecho --===============8385143125183962586==--