datafu-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <>
Subject Re: Review Request 25428: DATAFU-68 SampleByKey can throw NullPointerException
Date Wed, 24 Sep 2014 11:54:21 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 24, 2014, 11:54 a.m.)

Review request for DataFu.


Incorporated Matt's feedback.

Bugs: DATAFU-68

Repository: datafu


Attaching patch that:

* Fixes trailing whitespaces in the file
* Adds validation that signature is not null before calling hashCode
* Added check to intToRandomDouble to ensure that we won't use the null

Diffs (updated)

  datafu-pig/src/main/java/datafu/pig/sampling/ d94a038 



I didn't add new test case as I wasn't able to easily force Pig to call the method setUDFContextSignature
with null parameter on the unit test level. Existing unit tests are passing.


Jarek Cecho

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message