Return-Path: X-Original-To: apmail-datafu-dev-archive@minotaur.apache.org Delivered-To: apmail-datafu-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 850BC10890 for ; Tue, 18 Feb 2014 21:19:45 +0000 (UTC) Received: (qmail 76998 invoked by uid 500); 18 Feb 2014 21:19:44 -0000 Delivered-To: apmail-datafu-dev-archive@datafu.apache.org Received: (qmail 76968 invoked by uid 500); 18 Feb 2014 21:19:44 -0000 Mailing-List: contact dev-help@datafu.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@datafu.incubator.apache.org Delivered-To: mailing list dev@datafu.incubator.apache.org Received: (qmail 76960 invoked by uid 99); 18 Feb 2014 21:19:44 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 21:19:44 +0000 X-ASF-Spam-Status: No, hits=-2000.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 18 Feb 2014 21:19:42 +0000 Received: (qmail 75837 invoked by uid 99); 18 Feb 2014 21:19:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 21:19:20 +0000 Date: Tue, 18 Feb 2014 21:19:20 +0000 (UTC) From: "Matthew Hayes (JIRA)" To: dev@datafu.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (DATAFU-31) bags.DistinctBy works incorrectly on string containing minuses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DATAFU-31?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904614#comment-13904614 ] Matthew Hayes commented on DATAFU-31: ------------------------------------- Committed in d4a5c5d434c33c6b614ae08ee4179661fda0d358 > bags.DistinctBy works incorrectly on string containing minuses > -------------------------------------------------------------- > > Key: DATAFU-31 > URL: https://issues.apache.org/jira/browse/DATAFU-31 > Project: DataFu > Issue Type: Bug > Reporter: Roman Borisov > Assignee: jian wang > Fix For: 1.3.0 > > Attachments: 0001-fix-issue-bags.DistinctBy-works-incorrectly.patch > > > How to reproduce: > Input: > {(a-b,c), (a-b,d)} > define distinct as DistinctBy('1') > input = load 'input' as vs:bag{(v0:chararray,v1:chararray)}; > output = foreach input generate distinct(vs); > dump output; > expected: {(a-b,c), (a-b,d)} > actual: {(a-b,c)} > The bug is caused by the implementation based on splitting the tuple string by '-' to get tuple parts. -- This message was sent by Atlassian JIRA (v6.1.5#6160)