creadur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "P. Ottlinger" <pottlin...@apache.org>
Subject Re: Incremental RAT check triggered by GIT pre-commit
Date Tue, 29 Oct 2019 20:50:42 GMT
Fellow devs,

Am 28.10.19 um 17:58 schrieb Jarek Potiuk:
> Hello everyone,
> 
> Indeed I had a talk with Philipp. Unfortunately it seems that the
> exclude/include scenario is not really working for us. After talking to
> Philip I thought that we might want to even disable RAT as we have our own
> licence check/update (using pre-commit licence hook:
> https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml#L43)
> but I rethought it - I have improved a bit the interface and we have now a
> nice list of all files + licences shown in the output (we did not have it
> before) https://travis-ci.org/apache/airflow/jobs/603906260  and it's good
> it's checking all files (our solution has a closed list of file types we
> verify).
> 
> Having said that - it would be great if the command line interface of RAT
> could have the possibility of specifying files to check - then it would
> even better integrate with our pre-commit framework. Currently we do not
> run licence checks using pre-commit framework (it is effectively disabled
> an only runs if your run pre-commit with --all-files). I made it so that it
> is only triggered in case LICENCE* file change (which is pretty much
> never).
> 
> J.

Thanks Jarek,
I've created a jira issue for your request:
https://issues.apache.org/jira/browse/RAT-259

Would the proposed solution make sense for your use case?

Thanks,
Phil


Mime
View raw message