Mailing-List: contact rat-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: rat-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of hyrum_wright@mail.utexas.edu
 designates 146.6.25.6 as permitted sender)
DomainKey-Signature: s=main; d=mail.utexas.edu; c=nofws; q=dns;
  h=X-IronPort-MID:Received:Received:Received:Content-Type:
   Mime-Version:Subject:From:In-Reply-To:Date:
   Content-Transfer-Encoding:Message-Id:References:To:
   X-Mailer;
  b=cVgkLixTwHuZ4oPt3WNH+MzvX6mT8GFH+ngDmtbqsmQXWjM9tmUI4eSi
   LQFMh2tEaOQB3n0DWXUrfQyO0pwak9XFzRK+AMVIiYMeXdEVIn5UpjZ8t
   EMVgjrehA+aj2WNVJ6Ps7kzsyOdS8Ry+NyhGRinbRzZs8R7hRlkFRAsqc
   s=;
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1077)
Subject: Re: [PATCH] Allow RAT to run on .tar.gz archives
From: "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu>
In-Reply-To: <B38345AE-B676-44F0-9E94-60130B057A8E@mail.utexas.edu>
Date: Fri, 13 Nov 2009 22:29:43 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <529F2770-9AB7-4AFB-96C8-28F77A24CC42@mail.utexas.edu>
References: <B38345AE-B676-44F0-9E94-60130B057A8E@mail.utexas.edu>
To: rat-dev@incubator.apache.org

hmmm, it doesn't look like the patch attachment made it through.  What's =
the suggested way of supplying patches?

-Hyrum

On Nov 13, 2009, at 6:21 PM, Hyrum K. Wright wrote:

> In using RAT to check potential Subversion release tarballs, I've =
bumped into a couple of its, uh, limitations.  To that end, I've hacked =
up the attached patch which fixes the immediate itch of not wanting to =
have to unpack the tarball before running the tool.  I'm not sure what =
the RAT patch submission guidelines are, so I'm just sending it here, =
with the following caveats.
>=20
> Caveats:
> * Reports aren't sorted properly for .tar.gz; standard filesystem =
targets remain unaffected.
> * Needed to add a new dependency (ant) to pick up TarInputStream and =
friends.
> * My maven-fu is *very* limited (read: nonexistent) so I kind of =
guessed at the build system tweakage which needed to happen for the =
above.  Comments/pointers/tweaks appreciated.
> * My Java is a bit rusty, so I may not have done things in the most =
efficient way.
> * I don't know the standard RAT coding conventions, but attempted to =
follow existing conventions where possible.
>=20
> Future work:
> * Allow running on .zip and .tar.bz2 tarballs.  This should be =
relatively easy.
> * Properly sort the output of the report generated by running RAT on =
tarballs.
>=20
> Let me know of any feedback you may have, or feel free to just tweak =
the patch before committing.  I plan on implementing the followup =
patches after this one gets committed.
>=20
> Cheers,
> -Hyrum
>=20