couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [couchdb-erlfdb] nickva edited a comment on issue #2: Do not commit read-only transactions
Date Wed, 22 Apr 2020 16:32:28 GMT

nickva edited a comment on issue #2:
URL: https://github.com/apache/couchdb-erlfdb/pull/2#issuecomment-615981225


   For some reason this commit fails this test in couchdb on these tests with timeouts:
   
   ```
   make eunit apps=chttpd suites=chttpd_view_test
   make eunit apps=couch_views suites=couch_views_map_test
   ```
   
   It is probably because of some behavior related to waiting on futures as exposed by this
lower level couch_jobs test:
   
   ```
   make eunit apps=couch_jobs
         ....
         couch_jobs_tests:362: accept_blocking...*failed*
   in function couch_jobs_tests:'-accept_blocking/1-fun-2-'/3 (test/couch_jobs_tests.erl,
line 373)
   in call from eunit_proc:with_timeout/3 (eunit_proc.erl, line 325)
   **error:{assertMatch,[{module,couch_jobs_tests},
                 {line,373},
                 {expression,"WaitAccept ( Ref1 )"},
                 {pattern,"{ ok , # { id := J1 } , # { } }"},
                 {value,timeout}]}
     output:<<"">>
   ```
   
   Switching back to master erlfdb without this PR makes these tests pass. I suspect we might
need to commit so that we can start waiting on watches
   
   Confirmed via the API docs: https://apple.github.io/foundationdb/api-c.html#c.fdb_transaction_watch
   
   ```
   Until the transaction that created it has been committed, a watch will not report changes
made by other transactions
   ```
   
   And the source code: https://github.com/apple/foundationdb/blob/master/fdbclient/NativeAPI.actor.cpp#L2955
   
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message