From dev-return-48954-archive-asf-public=cust-asf.ponee.io@couchdb.apache.org Sat Dec 21 13:03:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9B123180630 for ; Sat, 21 Dec 2019 14:03:08 +0100 (CET) Received: (qmail 98822 invoked by uid 500); 21 Dec 2019 13:03:07 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 98809 invoked by uid 99); 21 Dec 2019 13:03:07 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Dec 2019 13:03:07 +0000 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id DF76E4FBC for ; Sat, 21 Dec 2019 13:03:06 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id n12so9112596lfe.3 for ; Sat, 21 Dec 2019 05:03:06 -0800 (PST) X-Gm-Message-State: APjAAAW9h8p3980OZfW8SDhpxtyKUBdaNgqebJIIdochosDsB4ah5EpQ jBfOXczDPDUkvFBThGIbfsZ8HWtHZdkefVH+lbyb+g== X-Google-Smtp-Source: APXvYqxBRrds/Ei6bSNcNy92THZAeOkKwutKCyAYxrIqrVgoTOp6bZmq2/Pf/ztBn7sG1VWqXfGZvv3clEwtcTadJ0w= X-Received: by 2002:ac2:5388:: with SMTP id g8mr11933729lfh.43.1576933385969; Sat, 21 Dec 2019 05:03:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Garren Smith Date: Sat, 21 Dec 2019 15:02:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [DISCUSS] Minor replicator error reporting API change To: dev@couchdb.apache.org Content-Type: multipart/alternative; boundary="0000000000004e3a22059a366a91" --0000000000004e3a22059a366a91 Content-Type: text/plain; charset="UTF-8" +1 nice improvement. We will have to check and possibly update Fauxton based on this change. Once this change is ready to go I can check Fauxton and make sure we support it or make any required changes. On Fri, Dec 20, 2019 at 8:47 PM Arturo GARCIA-VARGAS wrote: > +1 - It makes sense for any error object to have an error key > > On 20 December 2019 18:33:04 GMT+00:00, Nick Vatamaniuc < > vatamane@apache.org> wrote: > >Hi everyone, > > > >Before 3.0 goes out, I wanted to propose a minor replicator > >_scheduler/* API change. > > > >Currently when a replication job is crashing it reports the error as a > >string in the "info" field. So that that "info" field can be null, a > >string, or an object with various replication stats. > > > >The proposal is to turn the string into an object as well with an > >"error' field. So instead of > > > >{ > > ... > > "info": "some error message" > >} > > > >It will look like > > > >{ > > ... > > "info": {"error": "some error message"} > >} > > > >A few reasons for this change that it's a bit more consistent, and it > >should help with the some clients in static type language which have > >harder time handling an object being either a string, or an object, as > >opposed to a nullable fields and be different objects. > > > >What does everything think? > > > >Cheers, > >-Nick > --0000000000004e3a22059a366a91--