From dev-return-48878-archive-asf-public=cust-asf.ponee.io@couchdb.apache.org Tue Oct 29 22:36:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8DFA21804BB for ; Tue, 29 Oct 2019 23:36:36 +0100 (CET) Received: (qmail 79017 invoked by uid 500); 29 Oct 2019 22:36:35 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 78998 invoked by uid 99); 29 Oct 2019 22:36:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2019 22:36:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 97457C144D for ; Tue, 29 Oct 2019 22:36:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.198 X-Spam-Level: X-Spam-Status: No, score=-0.198 tagged_above=-999 required=6.31 tests=[KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id oAZUsQ_sNS6a for ; Tue, 29 Oct 2019 22:36:32 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.70.183.193; helo=relay1-d.mail.gandi.net; envelope-from=arturo@ficuslabs.com; receiver= Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 8012FC1981 for ; Tue, 29 Oct 2019 22:31:06 +0000 (UTC) X-Originating-IP: 188.29.164.251 Received: from [10.5.76.176] (188.29.164.251.threembb.co.uk [188.29.164.251]) (Authenticated sender: arturo@ficuslabs.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 4F39624000C for ; Tue, 29 Oct 2019 22:30:58 +0000 (UTC) Subject: Re: Batch mode options for CouchDB 4.0 To: dev@couchdb.apache.org References: <2fbcfcaa-ac2e-459c-94ff-20abad770786@www.fastmail.com> <337F7817-D8F8-4D1E-8278-B056CC019230@apache.org> From: Arturo GARCIA-VARGAS Message-ID: <18607dca-44f4-5860-b760-4cbf0e577191@ficuslabs.com> Date: Tue, 29 Oct 2019 22:30:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <337F7817-D8F8-4D1E-8278-B056CC019230@apache.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit I got a bit curious about this one. I see that batch=ok simply spawns the update. I am on couchdb master, and I can see the commit regarding _ensure_full_commit -it's now a no-op: commit dc054e7ddcc3ea059e1f86a7039cf86912ab1052 Author: Nick Vatamaniuc Date: Thu Sep 26 01:33:01 2019 -0400 ... 8< ... 8< ... 8< ... `/_ensure_full_commit` HTTP API was left as is since replicator from older versions of CouchDB would call that, it just returns the start time as if ensure_commit function was called. Issue: https://github.com/apache/couchdb/issues/2165 If there is no real /_ensure_full_commit anymore, then we cannot spawn anymore. Therefore, I personally think batch=ok should be removed altogether. > On 29/10/2019 19:10, Robert Newson wrote: > I am fine with returning 202 even though we blocked to complete the request. > > B. Seems like a good compromise until total deprecation, as spawning is not an option. Saludos! Arturo