Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Date: Wed, 2 Oct 2013 21:01:43 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Message-ID: <JIRA.12671965.1380728761911.2436.1380747703605@arcas>
In-Reply-To: <JIRA.12671965.1380728761911@arcas>
References: <JIRA.12671965.1380728761911@arcas>
Subject: [jira] [Commented] (COUCHDB-1901) Replicator needs to retry
 multipart requests atomically
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784423#comment-13784423 ] 

ASF subversion and git services commented on COUCHDB-1901:
----------------------------------------------------------

Commit df0423b5d5c35170626cfc0c10216d2e72e3a83e in branch refs/heads/1901-atomic-multipart-retries from [~kocolosk]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=df0423b ]

Bubble up missing_stub exceptions for proper retry

A missing_stub exception is special in that the replicator retries the
request without the atts_since optimmization.

COUCHDB-1901


> Replicator needs to retry multipart requests atomically
> -------------------------------------------------------
>
>                 Key: COUCHDB-1901
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1901
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Replication
>            Reporter: Adam Kocoloski
>            Assignee: Adam Kocoloski
>             Fix For: 1.5.0
>
>
> couch_replicator_httpc's retry mechanism interacts poorly with the multipart requests we use to transfer attachments during replication.  In the case of PUTs, the replicator will retry a request even though it has already streamed part of the request body.  For GETs, it can potentially interleave body data from the original response and the retried one.
> I put together a fix at https://github.com/cloudant/couch_replicator/pull/36 that disables the default httpc client retry mechanism for multipart requests and manages the retry logic "atomically"; i.e., it retries the original GET request if the GET or PUT fails, and it ensures that the original GET request is properly terminated during the retry.  I'll push a version of that patch to the Apache repo now.


--
This message was sent by Atlassian JIRA
(v6.1#6144)