Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7503994C2 for ; Mon, 7 Nov 2011 00:59:13 +0000 (UTC) Received: (qmail 76465 invoked by uid 500); 7 Nov 2011 00:59:12 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 76425 invoked by uid 500); 7 Nov 2011 00:59:12 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 76417 invoked by uid 99); 7 Nov 2011 00:59:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2011 00:59:12 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2011 00:59:11 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8336C34E20 for ; Mon, 7 Nov 2011 00:58:51 +0000 (UTC) Date: Mon, 7 Nov 2011 00:58:51 +0000 (UTC) From: "Klaus Trainer (Updated) (JIRA)" To: dev@couchdb.apache.org Message-ID: <1515242511.5447.1320627531538.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <659274089.31752.1319813612868.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (COUCHDB-1321) Vars in Rewrite rules break OAuth authentication MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COUCHDB-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Klaus Trainer updated COUCHDB-1321: ----------------------------------- Attachment: 0001-Fix-OAuth-that-broke-with-parameters-in-rewrites.patch The attached patch includes a fix and a test case that allows for reproducing the issue. In case you approve the solution, but object to the trailing white spaces being removed (which my editor did automatically), please tell me and I'll provide a whitespace-change-free version of the patch ;) > Vars in Rewrite rules break OAuth authentication > ------------------------------------------------ > > Key: COUCHDB-1321 > URL: https://issues.apache.org/jira/browse/COUCHDB-1321 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface > Affects Versions: 1.1 > Environment: Ubuntu > Reporter: Martin Higham > Priority: Minor > Attachments: 0001-Fix-OAuth-that-broke-with-parameters-in-rewrites.patch > > > When a rewrite rule containing a var ( such as /:name/myfunction ) matches an incoming request then an additional query param gets created. Unfortunately this new query param gets included in the Signature Base String when the OAuth code generates its version of the request signature to validate the incoming request it causing authentication to fail. > To fix this isn't straightforward. When a VHost is configured there is a handy copy of the original URL in (x-couchdb-vhost-path) that can be used to generate the Signature Base String, unfortunately if there isn't a VHost no such copy exists. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira