Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 3269 invoked from network); 8 Mar 2011 17:54:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Mar 2011 17:54:46 -0000 Received: (qmail 45096 invoked by uid 500); 8 Mar 2011 17:47:25 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 45018 invoked by uid 500); 8 Mar 2011 17:47:25 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 45005 invoked by uid 99); 8 Mar 2011 17:47:25 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Mar 2011 17:47:25 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Mar 2011 17:47:23 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 11A2D39DFF8 for ; Tue, 8 Mar 2011 17:47:01 +0000 (UTC) Date: Tue, 8 Mar 2011 17:47:01 +0000 (UTC) From: "Damien Katz (JIRA)" To: dev@couchdb.apache.org Message-ID: <51626659.5457.1299606421068.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <823419600.3437.1299550079623.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004089#comment-13004089 ] Damien Katz commented on COUCHDB-1084: -------------------------------------- Thanks for the feedback on the code style, we definitely want to clean it up before commiting. Right now I'm more interested on the performance impact and how fruitful removing the btree lookup is. I'm hoping this patch will improve performance for all writes, both inserts and updates, but I don't have time set up benchmarks right now. > Remove unnecessary btree lookup inside couch_db_updater > ------------------------------------------------------- > > Key: COUCHDB-1084 > URL: https://issues.apache.org/jira/browse/COUCHDB-1084 > Project: CouchDB > Issue Type: Improvement > Components: Database Core > Affects Versions: 1.2 > Reporter: Damien Katz > Assignee: Damien Katz > Attachments: remove_btree_lookup.patch > > > The CouchDB update process has an unnecessary btree lookup, where it reads the values in bulks, checks for conflicts, writes the docs to disk, updates the values appropriately and writes them to the btree out in a second step. It's possible to avoid this second step, and instead do all the checking, doc writing and value transformation in a single btree lookup, thereby reducing the number of btree traversals and disk IO. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira