Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Date: Tue, 1 Mar 2011 19:02:36 +0000 (UTC)
From: "Matt Adams (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Message-ID: 
 <2007915316.5739.1299006156911.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <9865963.3372.1298934517352.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] Commented: (COUCHDB-1078) Port couchjs to newest libmozjs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001023#comment-13001023 ] 

Matt Adams commented on COUCHDB-1078:
-------------------------------------

I suppose I should chime in here since this issue affects us directly.  While updating the Android port I found it impossible to use older versions of libmozjs: 1.7 is almost certainly a no-go unless someone wants to put a lot of time and energy into getting it to work and that doesn't seem smart for a piece of software that is nearing four years old.  Newer "versions" of libmozjs have much better support for Android and I suspect this will be the trend for some time.  This might not change Paul's mind (I don't entirely disagree with waiting for a new official release) but it is really important for those of us who are using Couch on Android.

As mentioned below I was able to fix the problem that Chris alluded to on Android and verified that libmozjs passes all tests on this platform (with the exception of the one test highlighted at http://wiki.apache.org/couchdb/Installing_on_Android).

14:44 <MattAdams> chrisccoulson: --> http://friendpaste.com/6cX8ZbAXeUqVvGCy6PCwyb_633739303139/raw
14:44 <MattAdams> You probably already have the http.c patch 
14:45 <MattAdams> The main.c patch is a result of a merge of my and your patch -- so it won't make sense to apply directly overtop of your patch but you get the idea.
14:46 <MattAdams> Basically the fix for the crash on Android was to comment out JS_SET_RVAL(cx, ...) and replace JS_TRUE with JS_FALSE.
14:46 <MattAdams> This may not be the "right" way to do it according to the JSAPI docs but it works and gives the Android version the same CTRL-D interaction as other versions.

> Port couchjs to newest libmozjs
> -------------------------------
>
>                 Key: COUCHDB-1078
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1078
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: JavaScript View Server
>    Affects Versions: 1.0.2
>            Reporter: Chris Coulson
>            Priority: Minor
>         Attachments: mozjs2.0.patch
>
>
> In the libmozjs shipped with Firefox 4 / xulrunner 2.0, jsapi has changed a fair bit. It would be nice to add support to couchjs for the latest libmozjs so Linux distro's don't have to support old versions of it.
> I already have a WIP patch for this

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira