Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Message-ID: <17123351.145451280869458061.JavaMail.jira@thor>
Date: Tue, 3 Aug 2010 17:04:18 -0400 (EDT)
From: "Filipe Manana (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Subject: [jira] Commented: (COUCHDB-842) Add JSON POST support to /_session
In-Reply-To: <28836511.144801280868136332.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895040#action_12895040 ] 

Filipe Manana commented on COUCHDB-842:
---------------------------------------

Hi Jonathan,

The patch looks good.

However, one thing it must have is a test (look into share/www/script/tests/*.js)

I would also prefer if:

- it uses the macro ?b2l instead of binary_to_list/1 (makes code more readable)
- it uses macro ?JSON_DECODE instead of couch_util:json_decode/1

Can you do it?

cheers


> Add JSON POST support to /_session
> ----------------------------------
>
>                 Key: COUCHDB-842
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-842
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: HTTP Interface
>    Affects Versions: 1.0
>            Reporter: Jonathan D. Knezek
>            Priority: Minor
>         Attachments: 0001-Add-JSON-POST-support-to-_session.patch
>
>
> With this patch the /_session POST handler will accept application/json content in the format of {"name":"myname","password":"mypass"}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.